Open
Conversation
HansOlsson
commented
Mar 5, 2026
henrikt-ma
reviewed
Mar 9, 2026
henrikt-ma
reviewed
Mar 9, 2026
henrikt-ma
reviewed
Mar 27, 2026
Comment on lines
+94
to
+97
| The right-hand side of the \lstinline!:=! is evaluated, and the resulting value is stored into the left-hand side variable or derivative. | ||
|
|
||
| The \lstinline[language=grammar]!expression! is evaluated. | ||
| The resulting value is stored into the variable denoted by \lstinline[language=grammar]!component-reference!. | ||
| The resulting value is stored into the variable denoted by \lstinline[language=grammar]!component-reference! (or as its derivative). | ||
| An assignment to a derivative may only occur in a model or block. |
Collaborator
There was a problem hiding this comment.
We are repeating ourselves too much regarding the storage of the result. Also, the paragraph break in the middle is strange. This is avoided with this good old suggestion:
Suggested change
| The right-hand side of the \lstinline!:=! is evaluated, and the resulting value is stored into the left-hand side variable or derivative. | |
| The \lstinline[language=grammar]!expression! is evaluated. | |
| The resulting value is stored into the variable denoted by \lstinline[language=grammar]!component-reference!. | |
| The resulting value is stored into the variable denoted by \lstinline[language=grammar]!component-reference! (or as its derivative). | |
| An assignment to a derivative may only occur in a model or block. | |
| (The restriction that \lstinline!der! is not allowed inside \lstinline!function! classes also applies to assignments.) | |
| The right-hand side of the \lstinline!:=! is evaluated, and the resulting value is stored into the left-hand side variable or derivative. |
henrikt-ma
requested changes
Mar 27, 2026
Collaborator
henrikt-ma
left a comment
henrikt-ma
left a comment
There was a problem hiding this comment.
Need to address repeated explanation and strange paragraph break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed.
Closes #3764