Conversation
Mind-the-Cap
left a comment
There was a problem hiding this comment.
Very good first draft, let's include all parameters!
examples/quickstart-fr.py.py
Outdated
| labels = pop_trips.get_prominent_cities() | ||
| pop_trips.plot_od_flows(labels=labels) | ||
|
|
||
| rapport = pop_trips.parameters_dict() |
There was a problem hiding this comment.
Good idea to put it here! Can we stick to English (report) ? Let's add a comment to help future users understand what it does
|
Suite à notre discussion, je propose les modifications suivantes :
|
|
New approach using class Parameter and function get_parameters in FileAsset
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 70.42% 70.50% +0.08%
==========================================
Files 56 56
Lines 2424 2431 +7
==========================================
+ Hits 1707 1714 +7
Misses 717 717 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…to use the new parameters handling method
…he number of files
Changes
|
…uted iteration (#261) * fix congestion propagation when using multiple runs * add checkpoints to population trips runs * cleanup * win 1252 to utf8 to avoid doc build issue * Avoid leakage of flows data between subsequent runs (#260) * fix congestion propagation when using multiple runs * win 1252 to utf8 to avoid doc build issue * Update README.md (#252) * Align stay-home baseline utility with min_activity_time_constant (#265) * Use saturation-weighted effective sink in destination sampling (#267) * Leisures (#262) * update the parsing of the leasure motive oppotunities * update the parsing of the leasure motive oppotunities * fix wrong leisure zones * update the branch to the main * fix PR issues on leisures * Align prepare_transport_zones with main * Fix types mismatch * reenable float64 cast --------- Co-authored-by: lucas_bohnenkamp0 <lucas.bohnenkamp@arep.fr> Co-authored-by: FlxPo <flx.pouchain@gmail.com> * replace clara clustering by kmeans + knn clustering (#271) * add state-transition waterfall diagnostic (#269) * add checkpoints to population trips runs * cleanup * [US] Établir un rapport de tous les paramètres d'entrée #198 (#240) * Parameter reporting via pydantic * avoid pydantic deprecation notice * fix tests * add parameters report to quickstart * allow mixing kwargs and pydantic parameters + update PopulationTrips to use the new parameters handling method * Population with pydantic model in inputs * update motives to use the new parameters handling method * update mobility surveys to use the new parameters handling method * update modes to use the new parameters handling method * move pydantic models alongside the class they are used in to remove the number of files --------- Co-authored-by: FlxPo <flx.pouchain@gmail.com> * add checkpoints to population trips runs * cleanup * fix congestion propagation when using multiple runs * add checkpoints to population trips runs --------- Co-authored-by: Cap <capucine-marin.dubroca-voisin@arep.fr> Co-authored-by: lucas-boh <83457283+lucas-boh@users.noreply.github.com> Co-authored-by: lucas_bohnenkamp0 <lucas.bohnenkamp@arep.fr> Co-authored-by: mariegrandclement <marie.grand-clement@arep.fr>
PR liée à l'US #198
Ajout d'une fonction parameters_dict dans la classe PopulationTrips pour récupérer les paramètres suivants :
Modification de la fonction plot_od_flows de la classe PopulationTrips pour afficher la liste des paramètres et le hash sur la carte.
Reste à faire :