Open
Conversation
Fishbowler
requested changes
Nov 19, 2024
Collaborator
Fishbowler
left a comment
Fishbowler
left a comment
There was a problem hiding this comment.
This is awesome! I've added a few minor nitpicks.
| @@ -8,9 +8,15 @@ To open a link on a device (i.e. a deep link): | |||
|
|
|||
| ### Auto verification of your Android Apps  | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| ### Auto verification of your Android Apps  | |
| ### Auto verification of your Android Apps |
|
|
||
| If not, the behavior would depend on the Android version of the device. | ||
|
|
||
| Starting from Android 12, such apps needs for the user to manually verify the association of the app with the domains through the "Open by default" settings menu. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Starting from Android 12, such apps needs for the user to manually verify the association of the app with the domains through the "Open by default" settings menu. | |
| Starting from Android 12, such apps need the user to manually verify the association of the app with the domains through the "Open by default" settings menu. |
Comment on lines
+53
to
+56
|
|
||
| | Accept | Sign in | Sync | Notifications | Ad privacy | Other ad privacy | | ||
| |-----------------------------------------------------------------------------------------------------------|--------------------------------------------------------------|-------------------------------------------------------------------------------------------------|------------------------------------------------------------------|----------------------------------------------------|--------------------------------------------------| | ||
| |  |  |  |  |  |  | |
Collaborator
There was a problem hiding this comment.
I'm not sure that these demonstrations are necessary. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's probably too verbose and has too many images but I'll let you edit it to your linking.
Linked #87
Linked mobile-dev-inc/Maestro#1999 (comment)