Update result summarizer to utilize id_json_file for public ids#446
Update result summarizer to utilize id_json_file for public ids#446ShriyaRishab merged 17 commits intomlcommons:masterfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@arav-agarwal2 can you please rebase? |
|
I believe I've done just that - let me know if I'm missing something |
|
WG discussed on 3/5/26 and planning to keep this open another week before finalizing. |
|
LGTM |
|
I've made a pass and have resolved your issues to the best of my ability. One thing I wanted to point out is that the ids currently are stored like "tinybox_green_privateid.json", where "tinybox_green" is the name for the system provided by the submitter. I understand this may be an issue ( as this could be changed by the submitter ), so if there's a better way to handle storage please let me know. |
|
Thanks, Arav. It looks great! |
|
I've added a few lines to the README as suggested. We should be A-OK for the merge. |
ShriyaRishab
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing all the concerns!
@pgmpablo157321 should be ok to merge
Part of resolving mlcommons/training#854
Adds a optional argument to supply id_json_path, a list of hashed ids which serves as a map from each result record to the actual repo ID.
Summaries will include both a hash column and an id column to ensure that each run is given a unique id and previous ids are respected.