fix: remove redundant -p flag from SGLang docker run command#198
Closed
Copilot wants to merge 2 commits intofeat/attafosu/sglang-openai-api-compatibilityfrom
Closed
fix: remove redundant -p flag from SGLang docker run command#198Copilot wants to merge 2 commits intofeat/attafosu/sglang-openai-api-compatibilityfrom
Copilot wants to merge 2 commits intofeat/attafosu/sglang-openai-api-compatibilityfrom
Conversation
10 tasks
Co-authored-by: attafosu <49414659+attafosu@users.noreply.github.com> Agent-Logs-Url: https://github.com/mlcommons/endpoints/sessions/b4dc4f1a-cd0e-4e35-915a-758e19a21b0d
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on sglang adapter and OpenAI API compatibility enhancements
fix: remove redundant -p flag from SGLang docker run command
Mar 24, 2026
|
MLCommons CLA bot: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--network=hostmakes-p 8000:8000a no-op, and the server launches on--port 8080anyway — the flag was both redundant and pointed at the wrong port.What does this PR do?
Removes
-p 8000:8000from the SGLangdocker runcommand in the Llama3.1-8B example. With--network=hostalready set, port publishing flags are ignored by Docker. The flag also referenced port 8000 while the server starts on 8080, which would have misled users troubleshooting connectivity.Type of change
Related issues
Testing
Checklist
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.