Skip to content

fix: remove redundant -p flag from SGLang docker run command#198

Closed
Copilot wants to merge 2 commits intofeat/attafosu/sglang-openai-api-compatibilityfrom
copilot/sub-pr-158
Closed

fix: remove redundant -p flag from SGLang docker run command#198
Copilot wants to merge 2 commits intofeat/attafosu/sglang-openai-api-compatibilityfrom
copilot/sub-pr-158

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 24, 2026

--network=host makes -p 8000:8000 a no-op, and the server launches on --port 8080 anyway — the flag was both redundant and pointed at the wrong port.

What does this PR do?

Removes -p 8000:8000 from the SGLang docker run command in the Llama3.1-8B example. With --network=host already set, port publishing flags are ignored by Docker. The flag also referenced port 8000 while the server starts on 8080, which would have misled users troubleshooting connectivity.

Type of change

  • Bug fix
  • Documentation update
  • New feature
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] [WIP] Address feedback on sglang adapter and OpenAI API compatibility enhancements fix: remove redundant -p flag from SGLang docker run command Mar 24, 2026
Copilot AI requested a review from attafosu March 24, 2026 00:15
@github-actions
Copy link
Copy Markdown

MLCommons CLA bot:
Thank you very much for your submission; we really appreciate it. Before we can accept your contribution,
we ask that you sign the MLCommons CLA (Apache 2). Please submit your GitHub ID to our onboarding form to initiate
authorization. If you are from a MLCommons member organization, we will request that you be added to the CLA.
If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact
support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
❌ @Copilot
You can retrigger this bot by commenting recheck in this Pull Request

@attafosu attafosu closed this Mar 24, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants