-
Notifications
You must be signed in to change notification settings - Fork 5
Elasticache Serverless implementation with default usage in CI and QA #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ardiea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Extra thoughts though. Should this really be its own component resource or should it be an implementation of OLAmazonCacheConfig named OLAmazonServerlessValkeyConfig().
Honestly, though I'm suggesting it, I think I like your implementation better just because the serverless configuration is really SOOO MUCH simpler than traditional elasticache configuration. OLAmazonCacheConfig comes with so much stuff that just isn't needed.
Only other thought is you've created one in the mitxonline stack but you don't actually point anything at it?
1c2a29a to
1f55e56
Compare
|
This has been applied to the Superset CI stack successfully, as well as verifying that applying it to the production Superset stack does not trigger any changes. |
1f55e56 to
72cdd03
Compare
|
This successfully deploys, but the serverless cache is also using the Redis "Cluster Mode" which means that all applications connecting to it need to be udpated to work with cluster mode, which is a larger body of work. |
What are the relevant tickets?
#3562
Description (What does it do?)
Add a serverless Valkey cache to help replace current instance based
How can this be tested?
pulumi up