Skip to content

Conversation

@feoh
Copy link
Contributor

@feoh feoh commented Sep 9, 2025

What are the relevant tickets?

#3562

Description (What does it do?)

Add a serverless Valkey cache to help replace current instance based

How can this be tested?

pulumi up

Copy link
Member

@Ardiea Ardiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Extra thoughts though. Should this really be its own component resource or should it be an implementation of OLAmazonCacheConfig named OLAmazonServerlessValkeyConfig().

Honestly, though I'm suggesting it, I think I like your implementation better just because the serverless configuration is really SOOO MUCH simpler than traditional elasticache configuration. OLAmazonCacheConfig comes with so much stuff that just isn't needed.

Only other thought is you've created one in the mitxonline stack but you don't actually point anything at it?

@blarghmatey blarghmatey force-pushed the cpatti/serverless_valkey branch 4 times, most recently from 1c2a29a to 1f55e56 Compare November 5, 2025 17:39
@blarghmatey blarghmatey changed the title Cpatti/serverless valkey Elasticache Serverless implementation with default usage in CI and QA Nov 5, 2025
@blarghmatey
Copy link
Member

This has been applied to the Superset CI stack successfully, as well as verifying that applying it to the production Superset stack does not trigger any changes.

@blarghmatey blarghmatey force-pushed the cpatti/serverless_valkey branch from 1f55e56 to 72cdd03 Compare November 5, 2025 18:03
@blarghmatey blarghmatey marked this pull request as draft November 5, 2025 18:14
@blarghmatey
Copy link
Member

This successfully deploys, but the serverless cache is also using the Redis "Cluster Mode" which means that all applications connecting to it need to be udpated to work with cluster mode, which is a larger body of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants