Unify Coq CI into a single .yml file #1798
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
force-pushed
the
unify-ci
branch
10 times, most recently
from
dc1b2e5 to
d8c82be
Compare
Collaborator
Author
|
Hm, probably it would be better to use reusable workflows rather than blocking future steps across platforms |
This shares structure a lot more, and will also enable us to (eventually) just check if the generated OCaml code is identical across Coq versions and platforms. Note that we no longer check generated files on most platforms, and we only validate on Coq master.
Contributor
|
I think branching on the platform inside a larger script isn't great. Reusable workflows might work, but I am not familiar with them. If we didn't have CI-specific workarounds, I think I would like to have a deps script for each platform and then source the right one. Unfortunately it seems that most of the files in this diff are full of stuff that is really specific to oddities of the proprietary CI infrastructure and I am not sure what to make of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shares structure a lot more, and will also enable us to (eventually) just check if the generated OCaml code is identical across Coq versions and platforms.
Note that we no longer check generated files on most platforms, and we only validate on Coq master.