Fix GCP hook: preserve httpx request extensions (timeout_ms) #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
Root cause
GoogleCloudBeforeRequestHook.before_requestrebuilds anhttpx.Requestwithout forwardingrequest.extensions. httpx stores per-request timeout configuration inextensions, sotimeout_msis dropped and the default timeout is used.Change
request.extensionswhen creatingnext_requestby passingextensions=request.extensions.Tests
src/mistralai/extra/tests/test_gcp_timeout_extensions.pyasserting thetimeoutextension is preserved through the hook.