Skip to content

Conversation

@yuchiki
Copy link

@yuchiki yuchiki commented Mar 15, 2023

fix #10329

What

  • fix types of package/sw
  • typecheck packages/sw in CI.

Why

  • packages/sw is not typechecked now
  • and packages/sw's type information goes obsolete

Additional info (optional)

N/A

Checklist

  • Read the contribution guide
  • [-] Test working in a local environment
    • all checks except for Test(backend) now succeed
      • Test(backend) is broken now in develop

@yuchiki yuchiki marked this pull request as draft March 15, 2023 02:16
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #10331 (b6eb18b) into develop (a561b83) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10331   +/-   ##
========================================
  Coverage    78.70%   78.70%           
========================================
  Files          161      161           
  Lines        19766    19766           
  Branches       332      332           
========================================
  Hits         15556    15556           
  Misses        4210     4210           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saschanaz
Copy link
Member

misskey-dev/misskey.js#56 のマージを要求する隊

@yuchiki yuchiki force-pushed the correctly-typed-sw branch from a0bd179 to b6eb18b Compare April 6, 2023 14:57
@tamaina
Copy link
Contributor

tamaina commented Apr 14, 2023

🙏

@tamaina tamaina closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packages/sw and packages/frontend are not typechecked in CI, and do not typecheck successfully.

3 participants