Skip to content

Conversation

@csteeg
Copy link
Contributor

@csteeg csteeg commented Apr 6, 2011

No description provided.

@migueldeicaza
Copy link
Owner

Could you produce a diff between my branch and yours? It seems like this would at least let me see some of the changes. Currently the changes as made available on this pull request are hard to see since they consist mostly of newline changes

@csteeg
Copy link
Contributor Author

csteeg commented Apr 6, 2011

Yes, sorry for that. My last checkin fixes the newlines. The entire/fixed diff can be viewed here:
https://github.com/migueldeicaza/MonoTouch.Dialog/pull/45/files

@csteeg csteeg reopened this Apr 8, 2011
@migueldeicaza
Copy link
Owner

I got a few of the other patches, but I do not understand the radio changes.

Can you explain what the problem is, and what this patch changes to fix it?

@csteeg
Copy link
Contributor Author

csteeg commented Apr 11, 2011

The RadioSelectionAttribute has a target property, but that property is never used in the current code base. The current code base, just skips any Int-typed property. (So it is impossible to add a normal int field like Age)
Then, if such an int-typed property has a RadioSelectionAttribute, it requires the next property(!) to be an IEnumerable, no matter if the target property equals that member's name.

The change in my code is that whenever an IEnumerable is encountered, it looks for an int-member that has a RadioSelectionAttribute where Target is equal to the IEnumerable's name. Also, int typed members that don't have the RadioSelectionAttribute, ar added as entry elements to allow someone to input a number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants