-
Notifications
You must be signed in to change notification settings - Fork 44
Weekly Permissions sync 2026-01-10 #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs a weekly permissions sync that updates permission definitions and API paths in the permissions configuration files.
- Standardizes formatting (whitespace, indentation) across multiple permission entries
- Adds new permission scopes for MS-ServicePrincipal.Create and five ManagedIdentity operations (Read, Update, Delete, HardDelete, Restore)
- Adds new API paths for Windows Update policies, approvals, and rings
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| permissions/new/provisioningInfo.json | Formatting standardization (trailing spaces, indentation) and addition of new permission scopes for MS-ServicePrincipal.Create and ManagedIdentity operations |
| permissions/new/permissions.json | Addition of new Windows Update API paths for policies, approvals, and rings with GET, POST, DELETE, and PATCH methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "scheme": "DelegatedWork", | ||
| "environment": "PPE;public", | ||
| "isHidden": true, | ||
| "isEnabled": true, | ||
| "resourceAppId": "00000003-0000-0000-c000-000000000000" | ||
| } | ||
| ], | ||
| "LockboxSettings.ReadWrite.All": [ | ||
| { | ||
| "scheme": "DelegatedWork", | ||
| "environment": "PPE;public", | ||
| "isHidden": true, | ||
| "isEnabled": true, | ||
| "resourceAppId": "00000003-0000-0000-c000-000000000000" | ||
| } | ||
| ], | ||
| { | ||
| "scheme": "DelegatedWork", | ||
| "environment": "PPE;public", | ||
| "isHidden": true, | ||
| "isEnabled": true, | ||
| "resourceAppId": "00000003-0000-0000-c000-000000000000" | ||
| } | ||
| ], | ||
| "LockboxRequest.Read.All": [ | ||
| { | ||
| "scheme": "DelegatedWork", | ||
| "environment": "PPE;public", | ||
| "isHidden": true, | ||
| "isEnabled": true, | ||
| "resourceAppId": "00000003-0000-0000-c000-000000000000" | ||
| } | ||
| ], | ||
| { | ||
| "scheme": "DelegatedWork", | ||
| "environment": "PPE;public", | ||
| "isHidden": true, | ||
| "isEnabled": true, | ||
| "resourceAppId": "00000003-0000-0000-c000-000000000000" | ||
| } | ||
| ], | ||
| "LockboxRequest.ReadWrite.All": [ | ||
| { | ||
| "scheme": "DelegatedWork", | ||
| "environment": "PPE;public", | ||
| "isHidden": true, | ||
| "isEnabled": true, | ||
| "resourceAppId": "00000003-0000-0000-c000-000000000000" | ||
| } | ||
| ] | ||
| { | ||
| "scheme": "DelegatedWork", | ||
| "environment": "PPE;public", | ||
| "isHidden": true, | ||
| "isEnabled": true, | ||
| "resourceAppId": "00000003-0000-0000-c000-000000000000" | ||
| } |
Copilot
AI
Jan 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LockboxSettings and LockboxRequest permission entries are missing the "id" field, which is present in most other permission entries in the file. While this appears to be a pre-existing condition that's just being reformatted in this PR, it creates inconsistency in the data structure. Consider adding the "id" field to these entries for consistency with other permission definitions.
Weekly Permissions sync 2026-01-10