Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Feb 12, 2026

fyi @benibenj backported from hackathon

Copilot AI review requested due to automatic review settings February 12, 2026 15:38
@bpasero bpasero enabled auto-merge (squash) February 12, 2026 15:38
@bpasero bpasero self-assigned this Feb 12, 2026
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@joaomoreno

Matched files:

  • src/vs/base/browser/ui/grid/grid.ts
  • src/vs/base/browser/ui/grid/gridview.ts

@benibenj

Matched files:

  • src/vs/base/browser/ui/grid/grid.ts
  • src/vs/base/browser/ui/grid/gridview.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an opt-in way to keep specific views visible when maximizing a view in the base Grid/GridView UI component.

Changes:

  • Extend GridView.maximizeView to accept an excludeViews list that will not be hidden during maximization.
  • Plumb the new excludeViews parameter through Grid.maximizeView and document it.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/base/browser/ui/grid/gridview.ts Implements exclusion logic during maximization by skipping setChildVisible(false) for excluded views.
src/vs/base/browser/ui/grid/grid.ts Exposes the excludeViews parameter on the public Grid API and forwards it to GridView.

Copy link
Contributor

Copilot AI commented Feb 12, 2026

@bpasero I've opened a new pull request, #294953, to work on those changes. Once the pull request is ready, I'll request review from you.

@bpasero bpasero merged commit 6fb9c86 into main Feb 12, 2026
23 of 24 checks passed
@bpasero bpasero deleted the ben/tasty-meerkat branch February 12, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants