debt - remove AMD support of VSCode for web #285230
Draft
+244
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes AMD (Asynchronous Module Definition) loader support for VS Code web, simplifying the build and module loading architecture by consolidating to ESM-only.
Key Changes
- Consolidated
workbench.web.main.internal.tsandworkbench.web.main.ts- the internal file now simply re-exports from the main file - Removed AMD bridge code that loaded ESM modules via a loader plugin
- Inlined
nls.messages.tsfunctions intonls.tsand removed the separate module
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/workbench.web.main.ts |
Removed AMD bridge code (~100 lines); added all imports, service registrations, and exports previously in .internal.ts |
src/vs/workbench/workbench.web.main.internal.ts |
Simplified to re-export everything from workbench.web.main.js with backward compatibility notice |
src/vs/nls.ts |
Inlined getNLSMessages() and getNLSLanguage() functions from deleted nls.messages.ts |
src/vs/nls.messages.ts |
Deleted - no longer needed for AMD compatibility layer |
src/vs/code/browser/workbench/workbench.ts |
Updated import path from .internal.js to .web.main.js |
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusEntry.ts |
Added optional chaining for product.defaultChatAgent (defensive programming fix) |
eslint.config.js |
Removed workbench.web.main.internal.ts from exclusions; removed nls.messages.ts from glob pattern; simplified import restrictions for internal file |
build/lib/optimize.ts |
Removed special banner exclusion for workbench.web.main that was only needed for AMD bridge |
build/gulpfile.vscode.web.ts |
Removed AMD loader from build; removed internal file from entry points; updated file copying logic to rename workbench.web.main.js → workbench.web.main.internal.js for embedder compatibility |
.vscode/settings.json |
Added workbench.web.main.ts to TypeScript auto-import exclusions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.