Fix Ctrl+P text navigation in webview on macOS #285015
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, Ctrl+P is a standard emacs-style shortcut for moving to the previous line in text input controls. The current implementation incorrectly suppresses this shortcut by treating it as the Print command, which is Windows-specific behavior. This change adds macOS platform detection and modifies the isPrint() function to only suppress Ctrl+P on non-macOS platforms. On macOS, Cmd+P continues to correctly trigger the print behavior. Fixes microsoft#264957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #264957
On macOS, Ctrl+P is a standard emacs-style shortcut for moving to the previous line in text input controls (similar to Ctrl+A for beginning of line, Ctrl+E for end of line, Ctrl+N for next line). Currently, this shortcut is incorrectly suppressed in webviews because the code treats it as the Print command, which is Windows-specific behavior.
Changes
Testing