Skip to content

Set dirty state before registering working copy #284897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmitrivMS wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −6
Open

Set dirty state before registering working copy #284897

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdbc9eb
Set dirty state before registering working copy
dmitrivMS Dec 23, 2025
862319c
Merge branch 'main' into dev/dmitriv/reopen-dirty-untitlied
dmitrivMS Dec 26, 2025
3106d1e
Merge branch 'main' into dev/dmitriv/reopen-dirty-untitlied
dmitrivMS Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/vs/workbench/api/browser/mainThreadCustomEditors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ class MainThreadCustomEditorModel extends ResourceWorkingCopy implements ICustom
private _currentEditIndex: number = -1;
private _savePoint: number = -1;
private readonly _edits: Array<number> = [];
private _isDirtyFromContentChange = false;
private _isDirtyFromContentChange: boolean;

private _ongoingSave?: CancelablePromise<void>;

Expand Down Expand Up @@ -390,18 +390,17 @@ class MainThreadCustomEditorModel extends ResourceWorkingCopy implements ICustom

this._fromBackup = fromBackup;

// Normally means we're re-opening an untitled file (set this before registering the working copy
// so that dirty state is correct when first queried).
this._isDirtyFromContentChange = startDirty;

if (_editable) {
this._register(workingCopyService.registerWorkingCopy(this));

this._register(extensionService.onWillStop(e => {
e.veto(true, localize('vetoExtHostRestart', "An extension provided editor for '{0}' is still open that would close otherwise.", this.name));
}));
}

// Normally means we're re-opening an untitled file
if (startDirty) {
this._isDirtyFromContentChange = true;
}
}

get editorResource() {
Expand Down
Loading