make terminal output feature accessible to screen reader users #276211
+132
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an accessible view for chat terminal tool output, allowing screen reader users to access terminal command output from chat tool invocations. It also renames the TerminalChat accessibility verbosity setting to TerminalInlineChat for clarity.
Key changes:
- Adds new
ChatTerminalOutputAccessibleViewto provide accessible terminal output content - Introduces
inChatTerminalToolOutputcontext key to track focus state - Renames
AccessibilityVerbositySettingId.TerminalChattoTerminalInlineChatfor consistency - Adds new
TerminalChatOutputverbosity setting for the terminal output accessible view - Implements focus tracking and aria-label management in
ChatTerminalToolProgressPart
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatAccessibilityHelp.ts | Updates reference from TerminalChat to TerminalInlineChat setting ID |
| src/vs/workbench/contrib/terminalContrib/chat/browser/terminal.initialHint.contribution.ts | Updates two references from TerminalChat to TerminalInlineChat setting ID |
| src/vs/workbench/contrib/chat/common/chatContextKeys.ts | Adds new context key for terminal tool output focus tracking |
| src/vs/workbench/contrib/chat/browser/chatTerminalOutputAccessibleView.ts | New file implementing the accessible view for terminal output |
| src/vs/workbench/contrib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts | Adds focus tracking, aria-label management, and accessible view support |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Registers the new ChatTerminalOutputAccessibleView |
| src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts | Renames TerminalChat to TerminalInlineChat and adds new TerminalChatOutput setting |
| src/vs/platform/accessibility/browser/accessibleView.ts | Adds ChatTerminalOutput provider ID |
...ch/contrib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts
Outdated
Show resolved
Hide resolved
...ch/contrib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts
Show resolved
Hide resolved
…ocationParts/chatTerminalToolProgressPart.ts Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #274220
If/when we end up using xterm here instead, we can reuse all of this and just change the
getCommandAndOutputAsTextfunction.