feat: add support to big endian#43
Merged
alexdima merged 1 commit intomicrosoft:mainfrom Apr 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the WASM build configuration to support running vscode-oniguruma on big-endian systems (e.g., AIX/s390), addressing interoperability issues observed by Node.js consumers.
Changes:
- Enable Emscripten big-endian support in the WASM build by adding
-s SUPPORT_BIG_ENDIAN=1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexdima
approved these changes
Apr 14, 2026
bryanchen-d
approved these changes
Apr 14, 2026
Contributor
Author
|
I forgot to update the PR description explaining what the flag entails to, but it pretty much enables explicit support to "Big Endian-based systems" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (Node.js) are facing issues with vscode-oniguruma in certain machines such as AIX/s390.
Ref: nodejs/node#62512