Skip to content

Conversation

@aasimkhan30
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

  1. Clipboard reliability in SSH/remote scenarios
    This PR updates the copy workflow to ensure reliable behavior in remote SSH environments. Previously, the copy string was generated in STS, which also attempted to write it to the clipboard — a process that was often unreliable. Now, STS returns the copy string to the extension, and the clipboard write happens locally.
    Fixes Copy to clipboard from Results not working #20747

  2. Reduce unnecessary progress notifications
    Progress notifications are no longer shown for copy operations that fall below the in-memory row threshold. These operations complete almost instantly, and the brief notification created unnecessary UI noise.

  3. New-line setting now respected
    This change also resolves an issue where the configured new-line setting was not being applied.
    Fixes [Bug]: New Line does not copy from results #20752 (implementation in STS PR Fixing copy new line settings variable in extension.  sqltoolsservice#2557).

  4. More reliable sorted/filtered row detection
    The PR also switches to a better way for detecting sorted or filtered rows in the query grid, addressing scenarios where the previous approach failed intermittently.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5289 KB 5289 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )
data-workspace VSIX null KB 542 KB ⚪ 542 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.64%. Comparing base (7a64047) to head (3444a54).

Files with missing lines Patch % Lines
extensions/mssql/src/controllers/queryRunner.ts 79.41% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20870      +/-   ##
==========================================
+ Coverage   66.61%   66.64%   +0.02%     
==========================================
  Files         210      210              
  Lines       20272    20277       +5     
  Branches     2638     2639       +1     
==========================================
+ Hits        13504    13513       +9     
+ Misses       6671     6666       -5     
- Partials       97       98       +1     
Files with missing lines Coverage Δ
extensions/mssql/src/configurations/config.ts 100.00% <ø> (ø)
extensions/mssql/src/controllers/queryRunner.ts 61.80% <79.41%> (+1.43%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: New Line does not copy from results Copy to clipboard from Results not working

3 participants