-
Notifications
You must be signed in to change notification settings - Fork 334
Fix optional Content-Type headers being transformed to enums (emitter-only) #9495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-optional-content-type-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+100
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to Method for optional Content-Type headers Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Copilot
AI
changed the title
[WIP] Fix optional contentType issue
Fix optional Content-Type headers treated as constants
Jan 28, 2026
…ansformation Co-authored-by: JoshLove-msft <[email protected]>
Copilot
AI
changed the title
Fix optional Content-Type headers treated as constants
Fix optional Content-Type headers being transformed to enums
Jan 28, 2026
...sharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/RestClientProvider.cs
Show resolved
Hide resolved
...TypeSpec.Generator.ClientModel/test/Providers/RestClientProviders/RestClientProviderTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: JoshLove-msft <[email protected]>
Copilot
AI
changed the title
Fix optional Content-Type headers being transformed to enums
Fix optional Content-Type headers being transformed to enums (emitter-only)
Jan 28, 2026
packages/http-client-csharp/emitter/src/lib/operation-converter.ts
Outdated
Show resolved
Hide resolved
Contributor
|
No changes needing a change description found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional Content-Type headers were incorrectly transformed into extensible enums by the type converter. They must remain as constants.
Changes
Emitter (type-converter.ts)
Emitter (operation-converter.ts)
fromSdkTypeto enable Content-Type detectionEmitter Tests (operation-converter.test.ts)
Result
Content-Type headers now remain as constants in the type model instead of being transformed to enums when the body parameter is optional. This prevents the enum transformation while preserving the constant type information for downstream processing.
Note
This PR focuses solely on the emitter-side fix to prevent unwanted enum transformation. Generator-side handling of optional Content-Type parameters (if needed for conditional setting) will be addressed separately.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.