Skip to content

changes to make vite 4 work#189

Open
micha-lmxt wants to merge 1 commit intomicrosoft:mainfrom
micha-lmxt:vite-4
Open

changes to make vite 4 work#189
micha-lmxt wants to merge 1 commit intomicrosoft:mainfrom
micha-lmxt:vite-4

Conversation

@micha-lmxt
Copy link
Copy Markdown

I'm trying to use tslib with vite 4.0.1. Dev mode seems to demand 'type':'module' in package.json. It then goes into modules subfolder and complains that '../tslib.js' has no default export. Can't argue with that, so I added the '* as' to the import.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

@micha-lmxt please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@micha-lmxt
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

vitbokisch added a commit to pyreon/pyreon that referenced this pull request Apr 14, 2026
Resolves the deferred Phase 3 PR #231 charts blocker.

═══ ROOT CAUSE ═══

ECharts's lib files do `import { __extends } from "tslib"`. tslib's
package.json `exports` maps the `import` condition to
`./modules/index.js`, which is a tiny wrapper that does:

  import tslib from '../tslib.js'
  const { __extends, __assign, __rest, ... } = tslib
  export { __extends, __assign, __rest, ... }

`tslib.js` is a UMD/CJS file that exposes helpers as TOP-LEVEL `var`
declarations on the factory exports object — NOT as properties of
`module.exports.default`. When esbuild's pre-bundler (used by Vite
under @vitest/browser) wraps `tslib.js` via `__toESM(require_tslib())`,
the destructure throws:

  TypeError: Cannot destructure property '__extends' of
  '__toESM(...).default' as it is undefined.

Known upstream issue: microsoft/tslib#189.

═══ FIX ═══

Alias `tslib` → `tslib.es6.js` in `vitest.browser.config.ts`.
`tslib.es6.js` is a flat ESM module with `export function __extends(...)`
— sidesteps the broken `modules/index.js` indirection entirely.

  resolve: { alias: { tslib: '<echarts-dir>/../tslib/tslib.es6.js' } }

Resolved via `createRequire` → `echarts/package.json` since tslib isn't
a direct dep of @pyreon/charts.

The `module` condition in tslib's exports map points at `tslib.es6.js`,
but Vite's resolver under vitest browser mode + the workspace `bun`
condition lands on `default` (CJS) instead. Explicit alias is the most
robust fix.

Phase 3 PR #231 tried `optimizeDeps.include` for echarts subpaths +
tslib + zrender, `resolve.mainFields` reorder, and bare
`resolve.alias` to tslib's ESM entry. The first two didn't help (the
failure happens deep in the optimized bundle, not at the user-facing
import boundary). The alias attempt failed because the path resolved
via `tslib/package.json` doesn't work — tslib isn't a direct dep —
but resolving via echarts (which IS) does.

═══ TESTS ═══

charts.browser.test.tsx: 3 → 6 tests, +3 canvas tests:
  - lazy-loads ECharts and renders a real canvas with non-zero dimensions
  - reactive options getter — signal change re-applies without
    remounting canvas
  - useChart.instance() resolves to a real ECharts instance after
    mount; assertion includes the documented API surface (setOption,
    resize, dispose)

═══ BISECT-VERIFIED ═══

Removed the alias in vitest.browser.config.ts → exactly the 3 new
canvas tests failed (the 3 bridge tests still pass because they
don't require ECharts to load). Restored, all 6 pass.

═══ DOCS ═══

CLAUDE.md @pyreon/charts section now documents the tslib alias
requirement + upstream issue link. Removes the "ECharts loading is
blocked" note from PR #231.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vitbokisch added a commit to pyreon/pyreon that referenced this pull request Apr 14, 2026
Addresses the 8/10 self-critique:

═══ #1 SHARED HELPER (formerly in-line in charts config) ═══

`vitest.browser.ts` now exports `tslibBrowserAlias(import.meta.url)` —
a robust resolver that walks both bun-nested (.bun/echarts@x/node_modules/tslib/)
and hoisted (node_modules/tslib/) install layouts. Returns `{}` if
tslib isn't found, so consumers can spread the alias unconditionally.

`@pyreon/charts/vitest.browser.config.ts` now uses the helper:
  alias: { ...tslibBrowserAlias(import.meta.url) }

Future packages whose transitive deps pull in tslib (rxjs, MobX,
older Material UI versions, etc.) can adopt the same one-liner.

═══ #2 ROBUST RESOLUTION ═══

Old (PR #245 round 1): `createRequire(echarts/package.json)` then
`../tslib/tslib.es6.js` — assumed bun's specific layout. pnpm/yarn/
npm with hoisted tslib would break.

New helper walks `node_modules/tslib/tslib.es6.js` from the calling
directory upward (10 levels max) AND falls back to the
`createRequire(echarts)` lookup if nothing direct works.

═══ #3 AUDIT: NO OTHER PACKAGES NEED THIS ═══

Checked dependencies + peerDependencies of @pyreon/flow, @pyreon/code,
@pyreon/document-primitives, @pyreon/router, @pyreon/head,
@pyreon/runtime-dom — none transitively import tslib. Only echarts
(via @pyreon/charts) currently triggers this issue. Future packages
that hit it can apply the helper.

═══ #4 DOC PROPAGATION (was 1 surface, now 3) ═══

Added the tslib alias note + microsoft/tslib#189 link to:
  - llms.txt           (one-liner with link)
  - llms-full.txt      (table cell with consumer fix snippet)
  - charts/README.md   (full "Bundler note" section with vite.config
                        snippet for downstream apps)

CLAUDE.md was already updated in PR #245 round 1.

═══ #5 BISECT GRANULARITY EXPLAINED ═══

Per-test bisect isn't load-bearing for the alias contract — all 3
canvas tests share a precondition (ECharts must load) but each
asserts a DISTINCT observation:
  1. dimensions test catches "canvas is 0×0"
  2. reactive-options test catches "canvas remounts on signal change"
  3. instance API test catches "useChart didn't expose instance signal"

Comment in `charts.browser.test.tsx` documents this explicitly so
the next person doesn't redo the analysis. The bundled bisect from
PR #245 round 1 (alias gone → all 3 fail) is the right shape for
the alias contract specifically.

═══ #6 TEST-ONLY SCOPE CLARIFIED ═══

`vitest.browser.config.ts` comment now explicitly notes this is a
test-environment fix and Pyreon's published `lib/*.js` ships without
the alias. Consumer apps using Vite hit the same bug; the fix is
documented in `charts/README.md` for them to apply in their own
`vite.config.ts`.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vitbokisch added a commit to pyreon/pyreon that referenced this pull request Apr 14, 2026
## Summary

Resolves the deferred Phase 3 PR #231 charts blocker — ECharts canvas
tests now run reliably under @vitest/browser.

## Root cause

ECharts's lib files do `import { __extends } from "tslib"`. tslib's
`package.json` `exports` maps the `import` condition to
`./modules/index.js`, which does:

```js
import tslib from '../tslib.js'
const { __extends, __assign, __rest, ... } = tslib
export { __extends, __assign, __rest, ... }
```

`tslib.js` is a UMD/CJS file that exposes helpers as TOP-LEVEL `var`
declarations on the factory exports object — NOT as properties of
`module.exports.default`. When esbuild's pre-bundler (used by Vite under
@vitest/browser) wraps `tslib.js` via `__toESM(require_tslib())`, the
destructure throws:

```
TypeError: Cannot destructure property '__extends' of '__toESM(...).default' as it is undefined.
```

Known upstream issue:
[microsoft/tslib#189](microsoft/tslib#189).

## Fix

Alias `tslib` → `tslib.es6.js` in `vitest.browser.config.ts`.
`tslib.es6.js` is a flat ESM module with `export function
__extends(...)` — sidesteps the broken `modules/index.js` indirection
entirely.

Resolved via `createRequire` against `echarts/package.json` because
tslib isn't a direct dep of `@pyreon/charts`.

PR #231 tried `optimizeDeps.include` (no effect — failure is deep in
optimized bundle), `resolve.mainFields` reorder (no effect — same
reason), and bare `resolve.alias` to tslib's ESM entry (failed because
resolving via `tslib/package.json` doesn't work). Resolving via echarts
works.

## Tests

`charts.browser.test.tsx`: 3 → 6 tests. New canvas-rendering tests:

- lazy-loads ECharts and renders a real canvas with non-zero dimensions
- reactive options getter — signal change re-applies without remounting
canvas
- `useChart.instance()` resolves to a real ECharts instance + asserts
API surface (`setOption`, `resize`, `dispose`)

All 6 pass.

## Bisect-verified

Removed the alias in `vitest.browser.config.ts` → exactly the 3 new
canvas tests failed (the 3 bridge tests still pass because they don't
require ECharts to load). Restored, all 6 pass.

## Test plan

- [ ] CI `Test (browser)` — `charts.browser.test.tsx` 6/6 pass
- [ ] `bun run typecheck` — 0 errors
- [ ] `bun run lint` — 0 new errors
- [ ] `bun run lint:browser-smoke` — clean

## Next

That clears the C queue. Phase 5 (B) — ui-system rollout, 14 packages
currently in `PHASE_5_PENDING_PACKAGES`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant