Fix NuGet errors when consumed by apps #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our consumption of the
Microsoft.Windows.CppWinRTpackage reference to useUpdateinstead ofInclude(so at best it "updates" which version to use and doesn't conflict with what RNW wants) and removes the "duplicate reference" warning our customers see.I'm 99% we don't need the entry at all in newer RNW versions but leaving it for now to deal with older customers.
This PR also removes the NuGet
package.lock.jsonfile from the published npm package, as it takes the decision to use/respect lock files away from the customer.Microsoft Reviewers: Open in CodeFlow