Revert "openhcl: plumb AziHsmEnabled to UefiConfigBlob and dps (#2767)"#2834
Merged
maheeraeron merged 1 commit intomicrosoft:mainfrom Feb 25, 2026
Conversation
…soft#2767)" This reverts commit 07a1184.
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts commit 07a1184 which added Azure Identity HSM (AziHsm) support to OpenVMM's UEFI firmware configuration. The revert cleanly removes all traces of the azi_hsm_enabled configuration flag from the codebase.
Changes:
- Removed
azi_hsm_enabledconfiguration field from all layers of the stack (CLI args, config structs, UEFI config blob, GET protocol) - Removed two VMM integration tests (
azi_hsm_presentandazi_hsm_absent) - Corrected the UEFI Flags bitfield reserved bits from 33 to 34 after removing the 1-bit flag
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/multiarch.rs | Removed two AziHsm integration tests |
| vm/loader/src/uefi/config.rs | Removed azi_hsm_enabled flag from Flags bitfield and updated reserved bits |
| vm/devices/get/guest_emulation_transport/src/client.rs | Removed field assignment in client |
| vm/devices/get/guest_emulation_transport/src/api.rs | Removed azi_hsm_enabled from API structs |
| vm/devices/get/guest_emulation_device/src/test_utilities.rs | Removed field from test utilities |
| vm/devices/get/guest_emulation_device/src/resolver.rs | Removed field from resource resolver |
| vm/devices/get/guest_emulation_device/src/lib.rs | Removed field from GuestConfig and channel serialization |
| vm/devices/get/get_resources/src/lib.rs | Removed field from resource definitions |
| vm/devices/get/get_protocol/src/dps_json.rs | Removed field from DPS JSON protocol |
| petri/src/vm/openvmm/construct.rs | Removed field usage in VM construction |
| petri/src/vm/mod.rs | Removed with_azi_hsm_enabled builder method and UefiConfig field |
| petri/src/vm/hyperv/mod.rs | Removed field destructuring in Hyper-V backend |
| openvmm/openvmm_entry/src/lib.rs | Removed field usage in VM config construction |
| openvmm/openvmm_entry/src/cli_args.rs | Removed CLI argument definition |
| openvmm/openvmm_defs/src/config.rs | Removed field from LoadMode enum |
| openvmm/openvmm_core/src/worker/vm_loaders/uefi.rs | Removed builder method call and field from UefiLoadSettings |
| openvmm/openvmm_core/src/worker/dispatch.rs | Removed field destructuring in dispatch |
| openhcl/underhill_core/src/worker.rs | Removed field destructuring in isolated config validation |
| openhcl/underhill_core/src/loader/mod.rs | Removed flag setter in UEFI config writer |
mebersol
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 07a1184.