Skip to content

Revert "openhcl: plumb AziHsmEnabled to UefiConfigBlob and dps (#2767)"#2834

Merged
maheeraeron merged 1 commit intomicrosoft:mainfrom
maheeraeron:user/maheeraeron/revert-azihsmenabled-main
Feb 25, 2026
Merged

Revert "openhcl: plumb AziHsmEnabled to UefiConfigBlob and dps (#2767)"#2834
maheeraeron merged 1 commit intomicrosoft:mainfrom
maheeraeron:user/maheeraeron/revert-azihsmenabled-main

Conversation

@maheeraeron
Copy link
Contributor

This reverts commit 07a1184.

@github-actions github-actions bot added the unsafe Related to unsafe code label Feb 24, 2026
@github-actions
Copy link

⚠️ Unsafe Code Detected

This PR modifies files containing unsafe Rust code. Extra scrutiny is required during review.

For more on why we check whole files, instead of just diffs, check out the Rustonomicon

@maheeraeron maheeraeron marked this pull request as ready for review February 25, 2026 00:26
@maheeraeron maheeraeron requested a review from a team as a code owner February 25, 2026 00:26
Copilot AI review requested due to automatic review settings February 25, 2026 00:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts commit 07a1184 which added Azure Identity HSM (AziHsm) support to OpenVMM's UEFI firmware configuration. The revert cleanly removes all traces of the azi_hsm_enabled configuration flag from the codebase.

Changes:

  • Removed azi_hsm_enabled configuration field from all layers of the stack (CLI args, config structs, UEFI config blob, GET protocol)
  • Removed two VMM integration tests (azi_hsm_present and azi_hsm_absent)
  • Corrected the UEFI Flags bitfield reserved bits from 33 to 34 after removing the 1-bit flag

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vmm_tests/vmm_tests/tests/tests/multiarch.rs Removed two AziHsm integration tests
vm/loader/src/uefi/config.rs Removed azi_hsm_enabled flag from Flags bitfield and updated reserved bits
vm/devices/get/guest_emulation_transport/src/client.rs Removed field assignment in client
vm/devices/get/guest_emulation_transport/src/api.rs Removed azi_hsm_enabled from API structs
vm/devices/get/guest_emulation_device/src/test_utilities.rs Removed field from test utilities
vm/devices/get/guest_emulation_device/src/resolver.rs Removed field from resource resolver
vm/devices/get/guest_emulation_device/src/lib.rs Removed field from GuestConfig and channel serialization
vm/devices/get/get_resources/src/lib.rs Removed field from resource definitions
vm/devices/get/get_protocol/src/dps_json.rs Removed field from DPS JSON protocol
petri/src/vm/openvmm/construct.rs Removed field usage in VM construction
petri/src/vm/mod.rs Removed with_azi_hsm_enabled builder method and UefiConfig field
petri/src/vm/hyperv/mod.rs Removed field destructuring in Hyper-V backend
openvmm/openvmm_entry/src/lib.rs Removed field usage in VM config construction
openvmm/openvmm_entry/src/cli_args.rs Removed CLI argument definition
openvmm/openvmm_defs/src/config.rs Removed field from LoadMode enum
openvmm/openvmm_core/src/worker/vm_loaders/uefi.rs Removed builder method call and field from UefiLoadSettings
openvmm/openvmm_core/src/worker/dispatch.rs Removed field destructuring in dispatch
openhcl/underhill_core/src/worker.rs Removed field destructuring in isolated config validation
openhcl/underhill_core/src/loader/mod.rs Removed flag setter in UEFI config writer

@maheeraeron maheeraeron merged commit 82ff7ce into microsoft:main Feb 25, 2026
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unsafe Related to unsafe code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants