nix: update overlay version since we updated rust version#2828
nix: update overlay version since we updated rust version#2828justus-camp-microsoft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Nix development environment to match the workspace Rust toolchain version by bumping the pinned oxalica/rust-overlay commit, and documents the process for updating it when rust-version changes.
Changes:
- Bump the pinned
rust-overlaycommit + content hash inshell.nixso Nix can resolve Rust1.93. - Add developer documentation describing how to update the
rust-overlaypin and hash whenCargo.toml’srust-versionis bumped.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
shell.nix |
Updates the pinned rust-overlay tarball commit + sha256 to include Rust 1.93. |
Guide/src/dev_guide/dev_tools/flowey/nix.md |
Documents the steps to update the rust-overlay pin/hash when Rust is bumped. |
shell.nix
Outdated
| @@ -6,8 +6,8 @@ let | |||
| }; | |||
| # Pinned rust-overlay from stable branch | |||
There was a problem hiding this comment.
Can we add a comment here with the current Rust version number (1.93)? That way I'll find it when updating, since I usually just do a ctrl F for the version number lol.
There was a problem hiding this comment.
The rust version is in the comment now - let me know if you need anything else to make this easier since you're usually the one that updates our rust version
justus-camp-microsoft
force-pushed
the
fix_nix_shell
branch
from
c862b96 to
e28a42f
Compare
3 participants
When we updated Rust to 1.93, the oxalica rust overlay that Nix uses wasn't updated, which means the overlay doesn't have the right version of rust to use. This updates the commit for the overlay and also adds some instructions to figure out how to do so.