Fix aarch64 page table parsing for 5 level paging#158
Merged
cfernald merged 3 commits intomicrosoft:mainfrom Mar 4, 2026
Merged
Fix aarch64 page table parsing for 5 level paging#158cfernald merged 3 commits intomicrosoft:mainfrom
cfernald merged 3 commits intomicrosoft:mainfrom
Conversation
With 2511, the arm mmu library added support for an additional paging level. When this occurs the current debugger logic will underflow and start parsing the page tables with garbage levels and entry counts. This change updates the level calculation to reflect the arm mmu library changes.
There was a problem hiding this comment.
Pull request overview
Updates the AArch64 debugger’s page-table walking logic to account for the Arm MMU library introducing an additional paging level (5-level paging), preventing level calculation underflow that can lead to garbage parsing.
Changes:
- Change the page-table walker’s
TableLeveltype fromUINTNtoINTNto allow representing an extra top level. - Add a guard so
TableLevelbecomes-1whenT0SZ < MIN_T0SZ(5-level paging scenario).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apop5
approved these changes
Mar 4, 2026
kuqin12
approved these changes
Mar 4, 2026
os-d
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 2511, the arm mmu library added support for an additional paging level. When this occurs the current debugger logic will underflow and start parsing the page tables with garbage levels and entry counts. This change updates the level calculation to reflect the arm mmu library changes.
Description
With 2511, the arm mmu library added support for an additional paging level. When this occurs the current debugger logic will underflow and start parsing the page tables with garbage levels and entry counts. This change updates the level calculation to reflect the arm mmu library changes.
How This Was Tested
Tested on SBSA initial breakpoint
Integration Instructions
N/A