fix(localization): critical memory safety bugs in encoding conversion #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRITICAL FIXES: 1. Fixed NULL pointer dereference in SystemLocale::NextChar() - Added NULL check to prevent crash when start pointer is NULL - Prevents DoS attack via malformed encoding input 2. Fixed uninitialized pointer return in IConvCachePool::Borrow() - Explicitly set pCache to NULL after failed allocation - Prevents undefined behavior and potential memory corruption - Eliminates use-after-free/information disclosure risk These memory safety vulnerabilities affect the SQL Server PHP driver when handling user-provided data with specific encoding conditions.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@SajanGhimire1 Thanks for raising the PR for this fix, Can you please check why is the pipeline failing for all OSs and fix it, also I would like you to add some tests to check if the code that you have added really works. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRITICAL FIXES:
Fixed NULL pointer dereference in SystemLocale::NextChar()
Fixed uninitialized pointer return in IConvCachePool::Borrow()
These memory safety vulnerabilities affect the SQL Server PHP driver when handling user-provided data with specific encoding conditions.