Graphrag config #2119
Open
Graphrag config #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dworthen
force-pushed
the
graphrag-config
branch
from
bf9a1f9 to
baa3129
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the configuration loading system by removing the create_graphrag_config function and introducing a new load_config utility in the graphrag-common package. The changes centralize configuration parsing, improve error handling, and standardize how CLI overrides are applied across the codebase.
- Removed
create_graphrag_configfunction and replaced it with directGraphRagConfiginstantiation or the newgraphrag_common.config.load_configutility - Added
python-dotenvandpyyamldependencies tographrag-commonpackage - Updated CLI override format from dot-notation strings (e.g., "output.base_dir") to nested dictionaries
Reviewed Changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/graphrag-common/pyproject.toml | Added python-dotenv and pyyaml dependencies |
| packages/graphrag-common/graphrag_common/config/load_config.py | New configuration loader with improved error handling and flexible parsing |
| packages/graphrag-common/graphrag_common/config/init.py | Exports load_config and ConfigParsingError |
| packages/graphrag/graphrag/config/load_config.py | Refactored to use graphrag_common.config.load_config |
| packages/graphrag/graphrag/config/create_graphrag_config.py | Deleted - functionality replaced by direct GraphRagConfig instantiation |
| packages/graphrag/graphrag/cli/*.py | Updated to use nested dict overrides instead of dot-notation strings |
| tests/verbs/*.py | Replaced create_graphrag_config calls with direct GraphRagConfig instantiation |
| tests/unit/config/test_config.py | Updated config loading tests to match new API signature |
| tests/unit/load_config/* | New test suite for the load_config functionality |
| unified-search-app/app/*.py | Updated imports and config instantiation |
| docs/examples_notebooks/*.ipynb | Updated imports and minor formatting fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
natoverse
reviewed
Nov 5, 2025
natoverse
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
load_configtographrag-commonpackage.