refactor(core): consolidate format-building logic in utils#195
Open
ayeshurun wants to merge 5 commits intomicrosoft:mainfrom
Open
refactor(core): consolidate format-building logic in utils#195ayeshurun wants to merge 5 commits intomicrosoft:mainfrom
ayeshurun wants to merge 5 commits intomicrosoft:mainfrom
Conversation
This script benchmarks the startup performance of the CLI by measuring module import times, CLI invocation times, and heavy dependency loading. It allows comparisons against a baseline branch or tag.
…cmd_import_utils - Create shared resolve_definition_format utility in fab_item_util.py - Update fab_fs_export_item.py and fab_fs_import_item.py to use shared function - Add invalid_definition_format to ExportErrors with backward-compatible alias - Consolidate common format validation pattern across export/import commands Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ayeshurun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
Move
get_payloadand format-building logic fromItemclass tofab_cmd_import_utils✨ Description of new changes
get_payloadfromfab_item.pytoget_payload_for_item_typeinfab_cmd_import_utils.pywith a simplified generic implementation_build_import_definitioninto_build_definitioninfab_cmd_import_utils.py, usingdefinition_format_mappingto resolve format valuesresolve_definition_formatutil infab_item_util.pyused by both export and importErrorMessages.Export.invalid_definition_format🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.