Add support for modifier keys while scrolling in some terminals#766
Open
g-dg wants to merge 2 commits intomicrosoft:mainfrom
Open
Add support for modifier keys while scrolling in some terminals#766g-dg wants to merge 2 commits intomicrosoft:mainfrom
g-dg wants to merge 2 commits intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the shift (horizontal scroll) and alt (fast scroll) key modifiers while scrolling. It also adds support for horizontal scroll wheels.
Unfortunately, it doesn't work in every terminal. Here are my testing results with some terminals:
Testing results with various terminals
Not tested:
I didn't try any other terminal mouse tracking modes. For all I know, there may be one that gets more terminals to work, but changing it will probably mess up a whole bunch of other stuff.
Scrolling horizontally by 7 characters seems to be about the same as what VS Code does and fast scrolling is a 5x multiplier by default in VS Code. I wouldn't mind other people's opinions on these values though.
Cool project, BTW.