Open
Conversation
c44ab8a to
e1a890e
Compare
Author
|
@microsoft-github-policy-service agree |
Open
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class Docker artifacts to run Data Formulator via docker compose / docker build, bundling the Vite-built frontend into the Python runtime image and documenting container usage.
Changes:
- Introduces a multi-stage
Dockerfileto build the frontend and ship a Python runtime image that serves the bundled UI. - Adds
docker-compose.ymland.dockerignorefor easier local deployment and smaller build contexts. - Adds a minimal sandbox image Dockerfile and Docker usage documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| py-src/data_formulator/sandbox/Dockerfile.sandbox | Adds a minimal Python sandbox image definition for Docker-based code execution. |
| docker-compose.yml | Defines a compose service for running Data Formulator with persisted workspace data. |
| Dockerfile | Adds multi-stage Docker build (frontend build + Python runtime image). |
| DEVELOPMENT.md | Documents Docker quick-start and sandbox limitations in containers. |
| .dockerignore | Reduces Docker build context size and avoids leaking local artifacts/secrets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+37
| # Create a non-root user to run the application | ||
| RUN useradd -m -s /bin/bash appuser | ||
|
|
Comment on lines
+20
to
+21
| - path: .env | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #85: Add Docker support
Changes
This PR addresses the issue described above. Changes were developed on the
fix/85-add-docker-supportbranch.Related Issue