Fix case-sensitive property mismatch in CosmosChatHistoryProvider queries #3485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
SQL queries in
CosmosChatHistoryProviderusedc.Type(uppercase) while the document model defines[JsonProperty("type")](lowercase). Cosmos DB's case-sensitive queries failed to match any documents, causingGetMessageCountAsync()andClearMessagesAsync()to always return 0.Description
Changed queries:
GetMessageCountAsync()- line 555:c.Type→c.typeClearMessagesAsync()- line 585:c.Type→c.typeAdded tests:
GetMessageCountAsync_WithMessages_ShouldReturnCorrectCountAsyncGetMessageCountAsync_WithNoMessages_ShouldReturnZeroAsyncClearMessagesAsync_WithMessages_ShouldDeleteAndReturnCountAsyncClearMessagesAsync_WithNoMessages_ShouldReturnZeroAsyncTests follow existing patterns (skip when Cosmos DB Emulator unavailable).
Contribution Checklist
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.