Initial support for volume mounting in CLI

[AmelBawa-msft]

Summary of the Pull Request

🦞 Volume mounting parser

Parser support examples:

✅ Valid

C:\data:/data
C:\data:/data:ro
C:/data:/data
C:/data:/data:rw

❌ Invalid

:
::
::ro
C:\data:/data:z

🦐 Full example

# -v <host path>:<container path>[:mode]
wslc container run -v "C:/src/wsl/bin/x64/Debug/volume:/usr/share/nginx/html" -it --name demo2 nginx:alpine

PR Checklist

• Closes: Link to issue #xxx
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated if needed and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated if needed
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[Copilot]

Pull request overview

Adds initial CLI support for bind-mounting a host path into a container by parsing -v/--volume and wiring it into the container creation flow.

Changes:

• Introduces a VolumeMount model with a parser for <host path>:<container path>[:mode].
• Adds --volume/-v argument to wslc container run and wslc container create.
• Plumbs the parsed volume into WSLAContainerLauncher::AddVolume(...) during container creation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/windows/wslc/ContainerService.cpp	Applies parsed volume mount to the container launcher before creation.
src/windows/wslc/ContainerModel.h	Adds Volume option field and declares VolumeMount parsing API.
src/windows/wslc/ContainerModel.cpp	Implements parsing/splitting logic for Windows-drive-aware -v syntax.
src/windows/wslc/ContainerCommand.h	Exposes --volume/-v in run and create commands.
src/windows/wslc/CMakeLists.txt	Adds the new model implementation file to the build.

[Copilot]

THROW_HR_WITH_USER_ERROR formats the message with a wide format string (std::format(L"{}", Message)), so passing a narrow string literal here is likely not formattable and can break the build. Use a wide string literal (L"...") or a std::wstring/localized message instead.

[Copilot]

The parser currently allows empty host/container paths (e.g. ":" -> host="", container="" and "::ro" -> host="", container=""), but the PR description calls these invalid. Add validation that parts[0] and parts[1] are non-empty (and if a mode is present, it’s non-empty) before accepting the mount.

[Copilot]

Only a single --volume value is supported end-to-end (options store one string and CreateInternal mounts at most one volume). Since the argument parser allows specifying -v/--volume multiple times, earlier values will be silently overwritten and only the last mount will be applied. Consider changing Volume to a list and calling AddVolume for each entry, or explicitly detect duplicates and throw a user error.

Suggested change

	if (!options.Volume.empty())
	{
	auto volume = VolumeMount::Parse(options.Volume);
	auto host = wsl::shared::string::MultiByteToWide(volume.HostPath());
	auto container = volume.ContainerPath();
	containerLauncher.AddVolume(host, container, volume.IsReadOnly());
	if (!options.Volumes.empty())
	{
	for (const auto& volumeSpec : options.Volumes)
	{
	auto volume = VolumeMount::Parse(volumeSpec);
	auto host = wsl::shared::string::MultiByteToWide(volume.HostPath());
	auto container = volume.ContainerPath();
	containerLauncher.AddVolume(host, container, volume.IsReadOnly());
	}

[Copilot]

The help text for --volume doesn’t indicate that the flag takes a value or what format is expected. Align with the PR’s documented syntax (e.g. show <host>:<container>[:ro|rw]) to reduce user confusion.

Suggested change

	"-v, --volume: Bind mount a volume to the container",
	"-v, --volume <host>:<container>[:ro|rw]: Bind mount a volume into the container",

[Copilot]

The help text for --volume doesn’t indicate that the flag takes a value or what format is expected. Align with the documented syntax (e.g. <host>:<container>[:ro|rw]) to reduce user confusion.

[Copilot]

Same issue here: THROW_HR_WITH_USER_ERROR expects a message formattable with a wide std::format(L"{}", ...), so this narrow string literal can fail to compile. Use a wide string literal or a localized std::wstring message.