Merge the WSL Container SDK DLL project into the main feature branch by 1wizkid · Pull Request #14172 · microsoft/WSL

1wizkid · 2026-02-06T20:42:49Z

this adds a new project src/windows/wslcsdk and the necessary .h and cpp files to build the WSLCSDK.DLL.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

benhillis · 2026-02-06T21:51:57Z

I've updated the target branch.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 24 comments.

src/windows/WslcSDK/wslcsdk.h

src/windows/WslcSDK/wslcsdk.cpp

src/windows/WslcSDK/CMakeLists.txt

OneBlue

Thank you for doing this. Added a couple comments, most of the copilot comments seem to be accurate

src/windows/WslcSDK/wslcsdk.cpp

src/windows/WslcSDK/wslcsdk.h

src/windows/WslcSDK/WslcsdkPrivate.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-09T16:50:23Z

@1wizkid I've opened a new pull request, #14183, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

src/windows/WslcSDK/wslcsdk.cpp

src/windows/WslcSDK/wslcsdk.h

src/windows/WslcSDK/WslcsdkPrivate.h

src/windows/WslcSDK/wslcsdk.cpp

Update enum prefix to match naming convention.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Updated enum prefix to match naming convention.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

src/windows/WslcSDK/wslcsdk.h

src/windows/WslcSDK/wslcsdk.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

OneBlue

A couple minor outstanding comments, but feel free to fix in a followup PR

OneBlue · 2026-02-12T19:31:17Z

src/windows/WslcSDK/wslcsdk.h

+
+STDAPI WslcProcessGetState(_In_ WslcProcess process, _Out_ WslcProcessState* state);
+
+STDAPI WslcProcessGetExitCode(_In_ WslcProcess process, _Out_ PINT32 exitCode);


nit: int32_t*

nit: INT32* per win32 api design guideline, same for other basic types across this file.

https://www.osgwiki.com/wiki/Win32_API_Design_Guidelines#Basic_Data_Types

OneBlue · 2026-02-12T19:32:11Z

src/windows/WslcSDK/wslcsdk.h

+typedef struct WslcImageInfo
+{
+    // we should expose this
+    PCSTR repository;


I thought I already had a comment for that, but I recommend using fixed size arrays here to make it nicer to the caller

richfr added 3 commits February 6, 2026 12:28

add the WSL Container SDK API DLL wslcsdk.dll

6c1746b

Add internal sdk header file

5076336

update primary cmakelists file with wslc sdk build

6802d4f

1wizkid requested a review from a team as a code owner February 6, 2026 20:42

1wizkid requested review from Brian-Perkins, OneBlue, benhillis, Copilot and craigloewen-msft February 6, 2026 20:42

Copilot AI reviewed Feb 6, 2026

View reviewed changes

benhillis changed the base branch from master to feature/wsl-for-apps February 6, 2026 21:51

benhillis requested a review from a team as a code owner February 6, 2026 21:51

benhillis requested review from Copilot and removed request for a team, Brian-Perkins and craigloewen-msft February 6, 2026 22:58

Copilot started reviewing on behalf of benhillis February 6, 2026 22:58 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

OneBlue requested changes Feb 7, 2026

View reviewed changes

1wizkid and others added 8 commits February 9, 2026 08:44

Update src/windows/WslcSDK/wslcsdk.h

9e817fd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

04b5fa0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

62b3272

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

9efaa38

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

625b73b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

94a4450

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

3faa5ea

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

2610162

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Feb 9, 2026

[WIP] Work in progress to address feedback on WSL SDK merge #14183

Closed

Merge branch 'feature/wsl-for-apps' into user/richfr

5b7a075

benhillis requested a review from Copilot February 11, 2026 23:20

Copilot started reviewing on behalf of benhillis February 11, 2026 23:21 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

1wizkid and others added 11 commits February 11, 2026 15:37

Fix enum prefix in WslcContainerNetworkingMode

02ec8b7

Update enum prefix to match naming convention.

Update src/windows/WslcSDK/WslcsdkPrivate.h

8da8691

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

2b1ab12

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update wslcsdk.cpp

578823a

Fix enum prefix in WslcContainerNetworkingMode

122c9b4

Updated enum prefix to match naming convention.

Refactor enum and type definitions for consistency

c49495e

Change UINT32 to uint32_t in wslcsdk.cpp

b9ae483

Change UINT32 to uint32_t in WslcsdkPrivate.h

21aa057

Fix formatting and comments in wslcsdk.h

631952e

Fix formatting and indentation in wslcsdk.h

b5bbbbd

Merge branch 'feature/wsl-for-apps' into user/richfr

4cf4682

benhillis requested a review from Copilot February 12, 2026 04:07

Copilot started reviewing on behalf of benhillis February 12, 2026 04:07 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

1wizkid and others added 10 commits February 11, 2026 20:23

Update src/windows/WslcSDK/wslcsdk.cpp

5fb2287

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.cpp

ef5d9a3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.cpp

8b54bf5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.cpp

186c26f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.cpp

a512f5a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.cpp

baca242

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.cpp

83e3d54

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/windows/WslcSDK/wslcsdk.h

fcc1687

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'feature/wsl-for-apps' into user/richfr

de75b49

Refactor WslcContainerSettingsSetPortMapping function

11b6423

OneBlue approved these changes Feb 12, 2026

View reviewed changes

1wizkid merged commit cb2595c into feature/wsl-for-apps Feb 12, 2026
6 checks passed


		STDAPI WslcProcessGetState(_In_ WslcProcess process, _Out_ WslcProcessState* state);

		STDAPI WslcProcessGetExitCode(_In_ WslcProcess process, _Out_ PINT32 exitCode);

Comments

Conversation

1wizkid commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

benhillis commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OneBlue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OneBlue left a comment

Choose a reason for hiding this comment

Uh oh!

OneBlue Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

yao-msft Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

OneBlue Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!