Use public version of nuget packages in AsyncCompletion sample #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Perhaps just delete the nuget.config file instead of pointing it to its default location? |
Contributor
|
@tinaschrepfer I guess you're now the PR merging authority here. |
|
I think the project itself needs to be updated. Most nugets dependencies need .NETFramework 4.7.2 yet the project is configured to target .NETFramework 4.6.1. So, Even when Installing the packages the project will force you to switch to .NETFramework 4.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The myget.org repo was deprecated and currently, the sample does not build.
This PR updates the sample so that it builds and correctly deploys to VS 2019 (this API is technically available, but not meant to be used in VS 2017)