Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mcp/src/olive_mcp/packages.py
Outdated
| elif command == CMD_QUANTIZE: | ||
| algorithm = kwargs.get("algorithm", "rtn") | ||
| impl = kwargs.get("implementation", "olive") | ||
| if impl == "bnb": | ||
| extras.add("bnb") | ||
| elif impl == "inc": | ||
| extras.add("inc") | ||
| elif impl == "autogptq" or algorithm == "gptq": | ||
| extra_packages.extend(["auto-gptq", "optimum", "datasets"]) | ||
| elif impl == "awq" or algorithm == "awq": | ||
| extra_packages.append("autoawq") | ||
| # Static quantization needs calibration data | ||
| if algorithm != "rtn": | ||
| extra_packages.append("datasets") |
There was a problem hiding this comment.
This information is available in olive_config.json. Rather not duplicate it here.
There was a problem hiding this comment.
I'm thinking in the soon future we need to split this feature out of Olive repo, as it is not a part of Olive. Any thoughts?
There was a problem hiding this comment.
Even if this is split out, it's likely to have a dependency on Olive. You could still load the olive_config from the dependency.
| job_log_fn(job_id, f"Reusing cached venv ({key})") | ||
|
|
||
| _touch_venv(venv_path) | ||
| return python_path |
There was a problem hiding this comment.
Might want to add a simple python -m pip list to show the status of the created environment.
There was a problem hiding this comment.
Pull request overview
Adds a new Olive MCP (Model Context Protocol) server under mcp/ to expose Olive workflows (optimize/quantize/finetune/benchmark/capture) as MCP tools, running long operations as background jobs in isolated uv-managed environments.
Changes:
- Introduces the
olive_mcpserver package (FastMCP server, tools, background job runner, worker process). - Implements per-command dependency resolution and cached
uv venvcreation to avoid ORT variant conflicts. - Adds packaging + docs for running the server (
pyproject.toml,uv.lock, README, example MCP configs).
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
mcp/src/olive_mcp/jobs.py |
Background job lifecycle, log streaming, parameter validation, concurrency limiting, error suggestions. |
mcp/src/olive_mcp/tools.py |
MCP tool surface (optimize/quantize/finetune/capture/benchmark/manage outputs) + prompts + job polling. |
mcp/src/olive_mcp/worker.py |
Worker entrypoint executing Olive CLI APIs and serializing workflow output to JSON. |
mcp/src/olive_mcp/packages.py |
Maps commands/options → olive-ai[extras] + extra dependencies for isolated env installs. |
mcp/src/olive_mcp/venv.py |
Cached uv venv creation/reuse + purging of old environments. |
mcp/src/olive_mcp/server.py |
FastMCP server instance + interaction instructions. |
mcp/src/olive_mcp/constants.py |
Shared constants/enums for commands/providers/precisions and dependency mapping. |
mcp/README.md |
Setup and usage documentation for MCP clients. |
mcp/pyproject.toml |
Packaging and olive-mcp script entrypoint. |
mcp/uv.lock |
Locked dependencies for the mcp/ subproject. |
mcp/.mcp.json.example / mcp/.gitignore / mcp/src/olive_mcp/__init__.py / __main__.py |
Project scaffolding and entrypoints. |
Describe your changes
Add olive mcp server
Checklist before requesting a review
lintrunner -a(Optional) Issue link