fix: all pipeline failures #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a static assertion that spuriously fails on MSVC that was version checked. Unfortunately it fires every time there is a new compiler update, so for now we will remove the version check and add it back once the compiler bug is fixed.
Looks like somewhere along the line, the iOS simulator changed the range of support iOS versions. This changes bumps the version from 9 to 12.0. Also noticed that the GSL OSX bundle version was quite out of date. I bumped this from 3.1.0 to 4.2.0 and created an upgrade checklist file in docs/ so we don't forget these types of tasks in the future.
…x-github-pipeline
carsonRadtke
force-pushed
the
carsonradtke/fix-github-pipeline
branch
from
60d663f to
ed516e2
Compare
carsonRadtke
added
Priority: Critical
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes multiple CI pipeline failures by updating platform versions and removing problematic compiler-specific workarounds. The changes address GitHub runner updates that changed iOS simulator support, Xcode versions, and Windows runner availability.
- Updated iOS deployment target from 9 to 12.0 and Xcode version from 15.4 to 16.4
- Replaced deprecated windows-2019 with windows-2025 and removed Visual Studio 16 2019 generator
- Simplified MSVC compiler workarounds by removing version-specific checks that break with new compiler updates
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/span_tests.cpp | Simplified MSVC compiler version checks to avoid breaking on new compiler updates |
| docs/upgrade_checklist.md | Added new checklist documentation for version upgrade procedures |
| .github/workflows/ios.yml | Updated iOS deployment target and bundle versions, added compiler flags |
| .github/workflows/compilers.yml | Updated Xcode version, replaced deprecated Windows runners, simplified Visual Studio matrix |
github-project-automation
bot
moved this to Open
in Microsoft/GSL Pull Requests In-Flight
carsonRadtke
moved this from Open
to Ready for Review
in Microsoft/GSL Pull Requests In-Flight
gdr-at-ms
approved these changes
Sep 30, 2025
github-project-automation
bot
moved this from Ready for Review
to Approved
in Microsoft/GSL Pull Requests In-Flight
github-project-automation
bot
moved this from Approved
to Merged
in Microsoft/GSL Pull Requests In-Flight
Copilot AI
pushed a commit
that referenced
this pull request
Dec 4, 2025
* fix: update conditional static assertion There is a static assertion that spuriously fails on MSVC that was version checked. Unfortunately it fires every time there is a new compiler update, so for now we will remove the version check and add it back once the compiler bug is fixed. * fix: ios pipeline failure Looks like somewhere along the line, the iOS simulator changed the range of support iOS versions. This changes bumps the version from 9 to 12.0. Also noticed that the GSL OSX bundle version was quite out of date. I bumped this from 3.1.0 to 4.2.0 and created an upgrade checklist file in docs/ so we don't forget these types of tasks in the future. * bump xcode version from 15.4 to 16.4 * fix compiler warning when building gtest for ios * allow for missing include dirs on command line * replace windows-2019 with windows-2025 * update visual studio versions after runner bump * PR feedback: make sure markdown links are syntactically correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like somewhere along the line, the iOS simulator changed the range of support iOS versions. This changes bumps the version from 9 to 12.0. Seems like this was probably caused by a GitHub runner update; it also affected the xcode version shipped with
macos-latest, so that has been bumped from 15.4 to 16.4. Also, windows-2019 has been deprecated, so it has been replaced by windows-2025 in our Visual Studio tests.Also noticed that the GSL OSX bundle version was quite out of date. I bumped this from 3.1.0 to 4.2.0 and created an upgrade checklist file in docs/ so we don't forget these types of tasks in the future.
Also there is a static assertion that spuriously fails on MSVC that was version checked. Unfortunately it fires every time there is a new compiler update, so for now we will remove the version check and add it back once the compiler bug is fixed.
This change does a lot, but each change is necessary because I can't get anything merged without doing all of the above.