Skip to content

[SM6.10][HLK] Use Template Load/Store for Shaders#8350

Draft
V-FEXrt wants to merge 7 commits intomicrosoft:mainfrom
V-FEXrt:lhi4
Draft

[SM6.10][HLK] Use Template Load/Store for Shaders#8350
V-FEXrt wants to merge 7 commits intomicrosoft:mainfrom
V-FEXrt:lhi4

Conversation

@V-FEXrt
Copy link
Copy Markdown
Collaborator

@V-FEXrt V-FEXrt commented Apr 7, 2026

Build on top of #8343, will move out of draft after that merges

Internal feedback was provided to use the templated Load/Store methods. This PR makes that change, and then simplifies the shaders/built in defines in response to those changes.

V-FEXrt and others added 6 commits April 6, 2026 17:10
This move requires the following non-move changes
- includes were updated
- doValuesMatch were marked inline to avoid redef errors
- using statements were added to LongVectors.cpp to match previous names
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 33656f65c2fd735647ed10448b1fa3ca7b1f2e48 c8abbaa814b103a204c81fe0295d6a11fd916e93 -- tools/clang/unittests/HLSLExec/HlslTestDataTypes.h tools/clang/unittests/HLSLExec/LinAlgTests.cpp tools/clang/unittests/HLSLExec/LongVectors.cpp
View the diff from clang-format here.
diff --git a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
index 6f4c5c54..2e4ce65d 100644
--- a/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
+++ b/tools/clang/unittests/HLSLExec/LinAlgTests.cpp
@@ -98,15 +98,15 @@ static std::string buildCompilerArgs(const MatrixParams &Params,
   SS << " -DELEM_SIZE=" << elementSize(Params.CompType);
   SS << " -DNUMTHREADS=" << Params.NumThreads;
   switch (Params.CompType) {
-    case ComponentType::F16:
-      SS << " -DELEM_TYPE=half";
-      break;
-    case ComponentType::F32:
-      SS << " -DELEM_TYPE=float";
-      break;
-    default:
-      SS << " -DELEM_TYPE=uint";
-      break;
+  case ComponentType::F16:
+    SS << " -DELEM_TYPE=half";
+    break;
+  case ComponentType::F32:
+    SS << " -DELEM_TYPE=float";
+    break;
+  default:
+    SS << " -DELEM_TYPE=uint";
+    break;
   }
   if (Params.EmulateTest)
     SS << " -DEMULATE_TEST";
  • Check this box to apply formatting changes to this branch.

Copy link
Copy Markdown
Member

@jenatali jenatali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for the actual commit that this PR is for, that's much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants