Change scope nested CFG passes to use a stack instead of recursion#8227
Open
jenatali wants to merge 3 commits intomicrosoft:mainfrom
Open
Change scope nested CFG passes to use a stack instead of recursion#8227jenatali wants to merge 3 commits intomicrosoft:mainfrom
jenatali wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
llvm-beanz
requested changes
Mar 5, 2026
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
This does not conform to our coding standards some obvious violations include:
llvm-beanz
reviewed
Mar 5, 2026
jenatali
force-pushed
the
scope-nested-fix
branch
from
b2475f9 to
ae0a74e
Compare
jenatali
commented
Mar 5, 2026
llvm-beanz
approved these changes
Mar 5, 2026
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
Thank you for the cleanups! I just have two small nits, otherwise this looks good to me.
Co-authored-by: Chris B <beanz@abolishcrlf.org>
bob80905
reviewed
Apr 6, 2026
| (*ReachableBBs) |= (*BTO.GetReachableBBs(pSuccBB)); | ||
| } | ||
| if (PushedChild) | ||
| continue; |
Collaborator
There was a problem hiding this comment.
I can't wrap my mind around how this is logically equivalent to the previous code, this looks like a behavioral change. Lines 1054-1074 here are the only lines I can't see the equivalent iterative translation for. Can you explain why we continue here? Maybe that would help explain the previous lines to me also. Other than those lines, this change looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8224