Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
06e2db5
initial implementaiton with runtime validity checks
henrypinkard Feb 26, 2025
1931993
Working with runtime checks for required properties
henrypinkard Feb 27, 2025
30de537
add comment
henrypinkard Feb 27, 2025
8789d67
cleanup
henrypinkard Feb 28, 2025
5759cc0
more cleanup
henrypinkard Feb 28, 2025
88833b1
change comment
henrypinkard Feb 28, 2025
e5ea9ce
add code review fixes
henrypinkard Mar 4, 2025
3633c1f
split camera base class into Base and LegacyBase
henrypinkard Mar 5, 2025
652991c
restore using statements
henrypinkard Mar 5, 2025
9c0bb8b
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 5, 2025
40c3d02
initial commit resuming previous work on camera api. Still have a com…
henrypinkard Mar 5, 2025
49b01c5
fix namespace and constructor errors from previous commits
henrypinkard Mar 5, 2025
1cef0b6
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 5, 2025
a85a54f
resotre commented code
henrypinkard Mar 5, 2025
9ff9c1f
fix more namespace issues
henrypinkard Mar 5, 2025
e250f83
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 5, 2025
60bd4b4
working build with basler camera
henrypinkard Mar 5, 2025
d0b45a8
converted many methods to standard properties
henrypinkard Mar 5, 2025
979d571
added mechanism for skipping required standard property
henrypinkard Mar 5, 2025
c496157
add skip standard props
henrypinkard Mar 5, 2025
79017f4
remove required flag from standard properties. Default to required an…
henrypinkard Mar 6, 2025
b37e5c3
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 6, 2025
5e6ab94
split out old and new camera api paths and clean up basler
henrypinkard Mar 6, 2025
a39a41c
remove from skipped registry upon creation
henrypinkard Mar 6, 2025
44ade7a
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 6, 2025
aa32a0c
Basler: standard prop action handlers
henrypinkard Mar 6, 2025
758e20b
standard properties must declare values at initialization
henrypinkard Mar 6, 2025
fd46240
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 6, 2025
5a4a894
basler progress
henrypinkard Mar 6, 2025
efdf7f9
successful auto-query of standard properties from basler
henrypinkard Mar 6, 2025
7766760
Events work in progress
henrypinkard Mar 7, 2025
da30e68
add method for updating standard property values
henrypinkard Mar 7, 2025
35f171c
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 7, 2025
c3bd38e
fix bug
henrypinkard Mar 7, 2025
a7ab1e2
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 7, 2025
9eac505
add checker method
henrypinkard Mar 7, 2025
5cd87df
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 7, 2025
2e4a937
WIP dynamic properties
henrypinkard Mar 7, 2025
a73d75e
add ability to dynamically delete properties
henrypinkard Mar 7, 2025
d210f4f
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 7, 2025
afca015
refactoring dynamic properties
henrypinkard Mar 7, 2025
9ca35fa
fix method name
henrypinkard Mar 7, 2025
71d6155
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 7, 2025
0a5b88b
readd skips
henrypinkard Mar 7, 2025
e1ebc27
remove from map correctly
henrypinkard Mar 7, 2025
d3d5cbb
Merge branch 'standard_props' into camera_api2025
henrypinkard Mar 7, 2025
f34266d
generic event handler
henrypinkard Mar 7, 2025
e4c396d
backwards compat for sequences in new camera API
henrypinkard Mar 8, 2025
3d7c29d
fix bug and only register handler once
henrypinkard Mar 8, 2025
f345c8f
allow snap to call insertImage instead of keeping its own buffer
henrypinkard Mar 8, 2025
6adb4bf
allow snap to call insertImage instead of keeping its own buffer
henrypinkard Mar 8, 2025
8a0dd5d
remove future new camera api changes
henrypinkard Mar 8, 2025
46d6ea0
complete merge
henrypinkard Mar 8, 2025
6183045
fix ncomponents
henrypinkard Mar 8, 2025
aed4e97
changes for multi-channel cameras
henrypinkard Mar 8, 2025
f6594f2
merge multi channel camera changes
henrypinkard Mar 9, 2025
b385397
change variable name
henrypinkard Mar 9, 2025
3bdfa47
merge multichannel camera fixes
henrypinkard Mar 9, 2025
4b47590
always return
henrypinkard Mar 9, 2025
75764f1
delete unused
henrypinkard Mar 9, 2025
786d872
Merge branch 'snap_insert_image' into camera_api2025
henrypinkard Mar 9, 2025
224e5e1
fix compiler warnings
henrypinkard Mar 9, 2025
f972ed1
Merge branch 'snap_insert_image' into camera_api2025
henrypinkard Mar 9, 2025
2db1497
finished adding new camera API to core
henrypinkard Mar 9, 2025
2a68d14
camera events/callbacks and more standard properties
henrypinkard Mar 11, 2025
1f242d2
enable frame burst property
henrypinkard Mar 11, 2025
9001af1
comment out rolling shutter standard props for now
henrypinkard Mar 14, 2025
221409b
remove commented
henrypinkard Mar 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DeviceAdapters/ABS/ABSCamera.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ const char* g_IOPort_None = " none";
* perform most of the initialization in the Initialize() method.
*/
CABSCamera::CABSCamera() :
CCameraBase<CABSCamera> (),
CLegacyCameraBase<CABSCamera> (),
dPhase_(0),
initialized_(false),
readoutUs_(1.0),
Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/ABS/ABSCamera.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ typedef std::map<std::string, u16> CIOPortNameToIndexMap; // io-po
typedef std::vector<std::string> CStringVector; // property names to handle transpose functions

//! abs camera class
class CABSCamera : public CCameraBase<CABSCamera>
class CABSCamera : public CLegacyCameraBase<CABSCamera>
{
friend class CABSCameraSequenceThread;

Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/AlliedVisionCamera/AlliedVisionCamera.h
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ class PixelFormatConverter
/**
* @brief Main Allied Vision Camera class
*/
class AlliedVisionCamera : public AlliedVisionDeviceBase<CCameraBase<AlliedVisionCamera>, AlliedVisionCamera>
class AlliedVisionCamera : public AlliedVisionDeviceBase<CLegacyCameraBase<AlliedVisionCamera>, AlliedVisionCamera>
{
///////////////////////////////////////////////////////////////////////////////
// PUBLIC
Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/AmScope/AmScope.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ MODULE_API void DeleteDevice(MM::Device* pDevice)
* perform most of the initialization in the Initialize() method.
*/
AmScope::AmScope() :
CCameraBase<AmScope> (),
CLegacyCameraBase<AmScope> (),
dPhase_(0),
binning_(1),
autoExposure_(1),
Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/AmScope/AmScope.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

class SequenceThread;

class AmScope : public CCameraBase<AmScope>
class AmScope : public CLegacyCameraBase<AmScope>
{
public:
AmScope();
Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/Andor/Andor.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class SRRFAndorCamera;
//////////////////////////////////////////////////////////////////////////////
// Implementation of the MMDevice and MMCamera interfaces
//
class AndorCamera : public CCameraBase<AndorCamera>
class AndorCamera : public CLegacyCameraBase<AndorCamera>
{
public:
friend class AcqSequenceThread;
Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/AndorSDK3/AndorSDK3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ MODULE_API void DeleteDevice(MM::Device * pDevice)
* perform most of the initialization in the Initialize() method.
*/
CAndorSDK3Camera::CAndorSDK3Camera()
: CCameraBase<CAndorSDK3Camera> (),
: CLegacyCameraBase<CAndorSDK3Camera> (),
deviceManager(NULL),
cameraDevice(NULL),
bufferControl(NULL),
Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/AndorSDK3/AndorSDK3.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class SRRFAndorSDK3Camera;
//////////////////////////////////////////////////////////////////////////////


class CAndorSDK3Camera : public CCameraBase<CAndorSDK3Camera>
class CAndorSDK3Camera : public CLegacyCameraBase<CAndorSDK3Camera>
{
public:
CAndorSDK3Camera();
Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/ArduinoCounter/ArduinoCounter.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class CameraSnapThread : public MMDeviceThreadBase
/*
* ArduinoCounter:
*/
class ArduinoCounterCamera : public CCameraBase<ArduinoCounterCamera>
class ArduinoCounterCamera : public CLegacyCameraBase<ArduinoCounterCamera>
{
public:
ArduinoCounterCamera();
Expand Down
8 changes: 4 additions & 4 deletions DeviceAdapters/Atik/Atik.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ int Atik::PrepareSequenceAcqusition()
int Atik::StartSequenceAcquisition(double interval) {

//log("");
return CCameraBase<Atik>::StartSequenceAcquisition(interval);
return CLegacyCameraBase<Atik>::StartSequenceAcquisition(interval);
}

/**
Expand All @@ -853,7 +853,7 @@ int Atik::StartSequenceAcquisition(double interval) {
int Atik::StopSequenceAcquisition()
{
//log("");
return CCameraBase<Atik>::StopSequenceAcquisition();
return CLegacyCameraBase<Atik>::StopSequenceAcquisition();
}

/**
Expand All @@ -864,7 +864,7 @@ int Atik::StopSequenceAcquisition()
int Atik::StartSequenceAcquisition(long numImages, double interval_ms, bool stopOnOverflow)
{
//log("");
return CCameraBase<Atik>::StartSequenceAcquisition(numImages, interval_ms, stopOnOverflow);
return CLegacyCameraBase<Atik>::StartSequenceAcquisition(numImages, interval_ms, stopOnOverflow);
}

/*
Expand Down Expand Up @@ -905,7 +905,7 @@ int Atik::InsertImage()

bool Atik::IsCapturing() {
log("");
return CCameraBase<Atik>::IsCapturing();
return CLegacyCameraBase<Atik>::IsCapturing();
}


Expand Down
2 changes: 1 addition & 1 deletion DeviceAdapters/Atik/Atik.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

class SequenceThread;

class Atik : public CCameraBase<Atik>
class Atik : public CLegacyCameraBase<Atik>
{
public:
Atik();
Expand Down
Loading
Loading