test: add tests #40
test: add tests #40
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive BATS (Bash Automated Testing System) test coverage for shell scripts in the repository. The tests validate script syntax, help/usage display, core functionality, and error handling across multiple utility scripts.
- Adds BATS test files for 8 shell scripts (venv-now, update-mine, touchx, mergewith, how-big, git-shed, chdirx, ach)
- Introduces shared test helper utilities with setup/teardown and custom assertions
- Integrates testing into CI workflow and adds Makefile targets for test execution
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_helper.bash | Provides common test infrastructure including setup/teardown, git repo initialization, and custom assertion helpers |
| tests/venv-now.bats | Tests Python virtual environment creation script with various flags and directory options |
| tests/update-mine.bats | Tests git branch update script including flag handling and repository validation |
| tests/touchx.bats | Tests executable file creation utility with single and multiple file handling |
| tests/mergewith.bats | Tests git merge helper script with branch validation and error scenarios |
| tests/how-big.bats | Tests directory size reporting utility including cross-platform compatibility notes |
| tests/git-shed.bats | Tests git branch cleanup script with dry-run mode and default branch handling |
| tests/chdirx.bats | Tests shebang file executable marker script with recursive directory processing |
| tests/ach.bats | Tests git blame ignore revision helper with custom file and hash options |
| Makefile | Adds test target with parallel execution support and integrates with check target |
| .github/workflows/CI.yml | Adds test job that runs BATS tests in parallel using bats-core/bats-action |
| .yamllint | Removes non-existent .yamlfmt file from yaml-files list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 19 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Michael I Chen <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Michael I Chen <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Michael I Chen <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
These tests are pretty strongly coupled to the current behavior, but I expect that to be pretty stable. At least we are testing now; it surfaced a ton of bugs on edge cases.