Skip to content

Conversation

@spehj
Copy link

@spehj spehj commented Feb 23, 2025

The example app uses deprecated imperative apply and can't be run. This PR migrates to the new apply decleratively.

Motivation for Change

When using this plugin, first thing is to try the example app. Example app fails to build with latest flutter version.

Description of Change

Deprecated imperative apply of Gradle plugins is migrated to the declarative apply.

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Related stories

None.

How has this been tested?

Run the example app and tried to connect&provision an ESP32. Everything is working fine.

Checklist

  • I have performed a self-review of my code.
  • If applicable, I have made necessary corresponding changes to the README.
  • I have added tests that prove my fix is effective or that my feature works.
  • If applicable, I have added screenshots or videos showing the example app UI changes I made.
  • ./format-and-analyze.sh succeeds.
  • Unit tests for all packages succeed.

spehj added 6 commits October 18, 2024 09:47
# Conflicts:
#	esp_provisioning/example/android/app/build.gradle
#	esp_provisioning/example/android/gradle/wrapper/gradle-wrapper.properties
#	esp_provisioning/pubspec.yaml
#	esp_provisioning_android/android/build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant