Update Ruff, replace pycln and simplify configs #2676
Conversation
Avasam
force-pushed
the
Update-Ruff-and-simplify-configs
branch
from
4346978 to
e231f97
Compare
| from . import ( | ||
| # https://github.com/astral-sh/ruff/issues/15705 | ||
| IDLEenvironment, # noqa: F401 # Injects fast_readline into the IDLE auto-indent extension |
There was a problem hiding this comment.
astral-sh/ruff#15705
This was also already affecting pycln
Avasam
changed the title
Avasam
changed the title
| # No such concerns for stdlib | ||
| "TC003", # typing-only-standard-library-import | ||
| # Lots of lazy or side-effect imports | ||
| "PLC0415", # import-outside-top-level |
There was a problem hiding this comment.
Added ignore for Ruff 0.12
ruff.toml
Outdated
| [lint.per-file-ignores] | ||
| # Explicit re-exports is fine in __init__.py, still a code smell elsewhere. | ||
| "__init__.py" = ["PLC0414"] | ||
| # TODO: Make adodbapi changes in their own PRs | ||
| "adodbapi/*" = ["C4", "YTT301", "UP031", "UP032"] |
There was a problem hiding this comment.
PLC0414 is now ignored in __init__.py by default
UP031 and UP032 are already ignored globally, so are redundant here.
YTT301 was already passing
C4 had 3 fairly minor and safe autofixes. (also solved by #233)
…e-Ruff-and-simplify-configs
…/Avasam/pywin32 into Update-Ruff-and-simplify-configs
…/Avasam/pywin32 into Update-Ruff-and-simplify-configs
| "*.pyw", # Will be included by default in Ruff eventually | ||
| "*.pys", # PythonScript (Windows Script Host) |
There was a problem hiding this comment.
Ruff will eventually autodiscover *.pyw files (currently undocumented astral-sh/ruff#21885 and preview-only)
.pys files are perfectly valid Python as well (I have absolutely no idea how someone runs them 😅, but they are valid)
There was a problem hiding this comment.
.pysfiles are perfectly valid Python as well (I have absolutely no idea how someone runs them 😅, but they are valid)
These are scripts for Python with a registered "windows scripting host" - ie, typically executed with cscript.exe.
2 participants
pycln was very useful as a starting point before all modules with intended side-effect were properly identified. Using Ruff instead reduces tooling dependencies, configs, special pragma comment keywords and time spent on CI.
*.pywand*.pysfiles