This repository was archived by the owner on Aug 11, 2025. It is now read-only.
[FS-1459]fix get inventory backward compatibility issue #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoctorVin
suggested changes
Jun 18, 2024
Contributor
DoctorVin
left a comment
DoctorVin
left a comment
There was a problem hiding this comment.
I think this is a good start but doesn't go far enough to ensure that this is actually fixed. I'm mostly concerned that there is data in the attributes table that is not well modeled even as an array of ComponentAttributes.
We should bring this up with the wider group as we plot how to fix this in the long term. Thinking more short-term, we should either make sure that ComponentAttributes contains all the data that is in that table or we could log failures to deserialize the attributes of a component and live with the consequences.
Alva8756
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will break the existing API tests for
getInventoryIf you are agree with this solution, I will work on fix the tests.