Add missing trition dep to BUCK target#2051
Open
lilyjanjigian wants to merge 1 commit intometa-pytorch:mainfrom
Open
Add missing trition dep to BUCK target#2051lilyjanjigian wants to merge 1 commit intometa-pytorch:mainfrom
lilyjanjigian wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Summary: The test_device_alltoallv_dynamic target was missing the triton dependency in its BUCK file. Without it, CI workers that don't have triton pre-installed hit ImportError at module load time, before any test skip logic could run. This caused all 34 tests to fail with "cannot import name 'flush_block' from 'torchcomms.triton.fb'". Add the triton dep so the module imports succeed. Individual tests that need CUDA still skip gracefully via unittest.skipUnless(CUDA_AVAILABLE). Also reverts the try/except import guards and SimpleNamespace stubs that were added as a workaround — they're no longer needed since triton is always available as a build dep. Differential Revision: D100182678
meta-cla
bot
added
the
CLA Signed
Contributor
|
@lilyjanjigian has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100182678. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The test_device_alltoallv_dynamic target was missing the triton dependency in its BUCK file. Without it, CI workers that don't have triton pre-installed hit ImportError at module load time, before any test skip logic could run. This caused all 34 tests to fail with "cannot import name 'flush_block' from 'torchcomms.triton.fb'".
Add the triton dep so the module imports succeed. Individual tests that need CUDA still skip gracefully via unittest.skipUnless(CUDA_AVAILABLE).
Also reverts the try/except import guards and SimpleNamespace stubs that were added as a workaround — they're no longer needed since triton is always available as a build dep.
Differential Revision: D100182678