[wip] Combine encoding into DeviceInterface #1213
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1213
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 66622e4 with merge base e93fc31 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
| return std::string("CPU Device Interface."); | ||
| } | ||
|
|
||
| UniqueAVFrame CpuDeviceInterface::convertTensorToAVFrameForEncoding( |
There was a problem hiding this comment.
CPU specific encoding implementation is removed from Encoder.cpp and added here.
| avFrame = convertTensorToAVFrame(currFrame, i); | ||
| } | ||
| UniqueAVFrame avFrame = deviceInterface_->convertTensorToAVFrameForEncoding( | ||
| currFrame, i, avCodecContext_.get()); |
There was a problem hiding this comment.
Device interface handles both CPU and CUDA, and removes repeated conditionals:
if (frames_.device().is_cuda && deviceInterface_) { ... }
| UniqueEncodingAVFormatContext avFormatContext_; | ||
| UniqueAVCodecContext avCodecContext_; | ||
| AVStream* avStream_ = nullptr; | ||
| UniqueSwsContext swsContext_; |
There was a problem hiding this comment.
This member variable is deleted in favor of the swsContext_ in CpuDeviceInterface.h.
| // It is here to isolate CUDA dependencies from CPU builds | ||
| // TODO Video-Encoder: Reconsider using video encoding functions in device | ||
| // interface | ||
| virtual UniqueAVFrame convertCUDATensorToAVFrameForEncoding( |
There was a problem hiding this comment.
We replace convertCUDATensor... with convertTensor... to integrate into the device interface pattern.
1 participant
No description provided.