Open
Conversation
- Fix src/core/ symlink issue by using src/openenv/core/ (7 files) - Fix build context paths for openapp_env and openspiel_env (2 files)
Contributor
Greptile OverviewGreptile SummaryThis PR fixes outdated COPY paths in Dockerfiles that were broken after the repository structure refactoring (commit 0dbaf14 from November 2025). The refactoring moved Changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Docker as Docker Build
participant Repo as Repository Root
participant Base as Base Dockerfile
participant Env as Environment Dockerfiles
Note over Dev,Env: Previous Structure (Broken)
Dev->>Docker: docker build (base image)
Docker->>Base: COPY src/core/pyproject.toml
Base-->>Docker: ❌ File not found (moved to root)
Dev->>Docker: docker build (env images)
Docker->>Env: COPY src/core/ /app/src/core/
Env-->>Docker: ❌ Directory not found (now src/openenv/core/)
Note over Dev,Env: New Structure (Fixed in this PR)
Dev->>Docker: docker build (base image)
Docker->>Base: COPY pyproject.toml
Base->>Repo: Read from repository root
Repo-->>Base: ✓ Found at root level
Base-->>Docker: ✓ Build successful
Dev->>Docker: docker build (env images)
Docker->>Env: COPY src/openenv/core/ /app/src/core/
Env->>Repo: Read from correct path
Repo-->>Env: ✓ Found at src/openenv/core/
Env-->>Docker: ✓ Build successful
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
Build and verify:
docker build -t openenv-base:latest -f src/openenv/core/containers/images/Dockerfile . && docker build -f envs/<env_name>/server/Dockerfile -t <env_name>:latest .Note: Encountered several environment/linting issues during development; uv sync appears to be missing dependencies (pydantic, ruff) required for the standard test/lint workflow as stated in CONTRIBUTING.md
Claude Code Review
NA