feat: local display names for nodes#4743
Open
gilindoesgit wants to merge 2 commits intomeshtastic:mainfrom
Open
feat: local display names for nodes#4743gilindoesgit wants to merge 2 commits intomeshtastic:mainfrom
gilindoesgit wants to merge 2 commits intomeshtastic:mainfrom
Conversation
added 2 commits
March 8, 2026 20:43
- Add NodeDisplayNamePrefs (DataStore) keyed by node number - Show custom name in node list, detail, and use in GetNodeDetailsUseCase - Add EditNodeDisplayNameSheet and 'Set display name' in list context menu - Add Display name row in node detail (tap to edit) - Unit tests for NodeDisplayNamePrefsImpl Made-with: Cursor
Made-with: Cursor
|
Meshtastic Contributor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local display names for nodes
Users can set a local display name for any node. That name is shown in the app instead of the device’s long/short name, and is stored only on the device (not sent over the mesh).
Summary
NodeDisplayNamePrefs(DataStore), keyed by node numberUI
Technical details
num), the unique node ID.num\u0001name\u0002…with escaping for names containing delimiters.set_display_name,display_name,display_name_hint,clear_display_name(default locale only in this PR).Testing
core/prefs/…/NodeDisplayNamePrefsTest.kt(defaults, set/get, clear, multiple nodes, trim)../gradlew :core:prefs:testDebugUnitTestChecklist