Skip to content

Conversation

@DHAWAN13
Copy link

Problem

Crow-foot markers in ER diagrams could appear misaligned across browsers and themes due to inconsistent SVG marker reference points.

Solution

Normalized marker geometry by centering refX relative to marker width, ensuring consistent attachment of crow-foot symbols to relationship edges.

Impact

  • Improved cross-browser rendering consistency
  • No visual redesign or breaking changes
  • Affects ER diagram markers only

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

⚠️ No Changeset found

Latest commit: 9f34c5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 9f34c5d
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/69440fb4fcddde0008099502
😎 Deploy Preview https://deploy-preview-7257--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 18, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7257

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7257

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7257

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7257

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7257

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7257

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7257

commit: 9f34c5d

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.56%. Comparing base (7b167cf) to head (9f34c5d).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/er/erMarkers.js 0.00% 50 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7257      +/-   ##
==========================================
- Coverage     3.56%   3.56%   -0.01%     
==========================================
  Files          473     473              
  Lines        47566   47585      +19     
  Branches       734     734              
==========================================
  Hits          1696    1696              
- Misses       45870   45889      +19     
Flag Coverage Δ
unit 3.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/er/erMarkers.js 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant