-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
7167 : fix classDef style application for treemap diagramtype #7178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7167 : fix classDef style application for treemap diagramtype #7178
Conversation
🦋 Changeset detectedLatest commit: 1aa4cd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7178 +/- ##
=======================================
Coverage 3.55% 3.55%
=======================================
Files 473 473
Lines 47500 47500
Branches 731 731
=======================================
Hits 1687 1687
Misses 45813 45813
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
sidharthv96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the argos changes validate this fix?
Yes @sidharthv96 , the Argos results validate the fix. I’ve also added 5 additional test cases to ensure broader coverage and confirm the behaviour. |
📑 Summary
This PR fixes the
classDefstyle application mechanism in treemap diagrams. Previously, user-defined styles viaclassDefwere not being applied correctly due to type inconsistencies and SVG attribute override issues. This fix ensures that treemap diagrams now properly respect custom styles defined throughclassDef, bringing them in line with other diagram types like flowchart and state diagrams.Resolves #7167
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.