Skip to content

Conversation

@darshanr0107
Copy link
Contributor

@darshanr0107 darshanr0107 commented Oct 8, 2025

📑 Summary

Restores the behavior that only nodes and edges delimited with double-quote-backtick (e.g. node["_markdown_ **text**"]) are processed as markdown.

Resolves #6275, #6048, and #5824

This PR is based upon #6345

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2025

🦋 Changeset detected

Latest commit: cf12603

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit cf12603
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/694e81d75585b300089cb65e
😎 Deploy Preview https://deploy-preview-7057--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 8, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7057

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7057

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7057

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7057

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7057

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7057

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7057

commit: cf12603

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 249 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.56%. Comparing base (d5bc07d) to head (cf12603).

Files with missing lines Patch % Lines
...c/rendering-util/rendering-elements/createLabel.js 0.00% 70 Missing ⚠️
...aid/src/rendering-util/rendering-elements/edges.js 0.00% 51 Missing ⚠️
...-util/rendering-elements/shapes/labelImageUtils.ts 0.00% 42 Missing ⚠️
...c/rendering-util/rendering-elements/shapes/util.ts 0.00% 27 Missing ⚠️
.../src/rendering-util/rendering-elements/clusters.js 0.00% 23 Missing ⚠️
packages/mermaid/src/diagrams/flowchart/flowDb.ts 0.00% 16 Missing ⚠️
...ng-util/rendering-elements/shapes/rectWithTitle.ts 0.00% 9 Missing ⚠️
.../rendering-util/rendering-elements/shapes/erBox.ts 0.00% 6 Missing ⚠️
packages/mermaid/src/dagre-wrapper/shapes/util.js 0.00% 2 Missing ⚠️
packages/mermaid/src/diagrams/kanban/kanbanDb.ts 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7057      +/-   ##
==========================================
- Coverage     3.57%   3.56%   -0.01%     
==========================================
  Files          473     475       +2     
  Lines        47475   47570      +95     
  Branches       734     735       +1     
==========================================
  Hits          1696    1696              
- Misses       45779   45874      +95     
Flag Coverage Δ
unit 3.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/flowchart/types.ts 100.00% <ø> (ø)
...kages/mermaid/src/diagrams/mindmap/mindmapTypes.ts 100.00% <ø> (ø)
packages/mermaid/src/types.ts 100.00% <ø> (ø)
packages/mermaid/src/diagrams/mindmap/mindmapDb.ts 0.00% <0.00%> (ø)
packages/mermaid/src/dagre-wrapper/shapes/util.js 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/kanban/kanbanDb.ts 0.00% <0.00%> (ø)
.../rendering-util/rendering-elements/shapes/erBox.ts 0.00% <0.00%> (ø)
...ng-util/rendering-elements/shapes/rectWithTitle.ts 0.78% <0.00%> (-0.04%) ⬇️
packages/mermaid/src/diagrams/flowchart/flowDb.ts 0.00% <0.00%> (ø)
.../src/rendering-util/rendering-elements/clusters.js 0.00% <0.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link

argos-ci bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 271 changed, 3 added Dec 26, 2025, 12:49 PM

darshanr0107 and others added 28 commits December 15, 2025 18:42
…ping behavior

- Add width parameter to createLabel function signature
- Pass node.width || config.flowchart.wrappingWidth from shapes/util.ts
- This ensures both createText and createLabel use the same width for text wrapping
- Fixes layout issues where text was not wrapping correctly in non-markdown labels
- Add proper JSDoc types to createLabel parameters
- Fix type errors in rectWithTitle.ts (handle undefined label and array description)
…rectWithTitle and labelHelper functions"

This reverts commit be6c19d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown-by-default for labels complicates the upgrade from Mermaid 10 to Mermaid 11

5 participants