-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Fix markdown labels for flowcharts #7057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Sidharth Vinod <[email protected]>
🦋 Changeset detectedLatest commit: cf12603 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…-js/mermaid into fix-markdown-labels-6087
…-js/mermaid into fix-markdown-labels-6087
…fix-markdown-labels-6087
on-behalf-of: @Mermaid-Chart <[email protected]>
This reverts commit 7e7354c.
…ilures" This reverts commit adbd763.
…-js/mermaid into fix-markdown-labels-6087
…fix-markdown-labels-6087
This reverts commit 8bf14ef.
…ping behavior - Add width parameter to createLabel function signature - Pass node.width || config.flowchart.wrappingWidth from shapes/util.ts - This ensures both createText and createLabel use the same width for text wrapping - Fixes layout issues where text was not wrapping correctly in non-markdown labels - Add proper JSDoc types to createLabel parameters - Fix type errors in rectWithTitle.ts (handle undefined label and array description)
on-behalf-of: @Mermaid-Chart <[email protected]>
on-behalf-of: @Mermaid-Chart <[email protected]>
on-behalf-of: @Mermaid-Chart <[email protected]>
on-behalf-of: @Mermaid-Chart <[email protected]>
on-behalf-of: @Mermaid-Chart <[email protected]>
on-behalf-of: @Mermaid-Chart <[email protected]>
…fix-markdown-labels-6087
…Title and labelHelper functions on-behalf-of: @Mermaid-Chart <[email protected]>
…ers" This reverts commit 76cb6f2.
…rectWithTitle and labelHelper functions" This reverts commit be6c19d.
…e from edge on-behalf-of: @Mermaid-Chart <[email protected]>
…ify logic on-behalf-of: @Mermaid-Chart <[email protected]>
on-behalf-of: @Mermaid-Chart <[email protected]>
📑 Summary
Restores the behavior that only nodes and edges delimited with double-quote-backtick (e.g. node["
_markdown_ **text**"]) are processed as markdown.Resolves #6275, #6048, and #5824
This PR is based upon #6345
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.