Skip to content

Conversation

@bwinsley
Copy link

@bwinsley bwinsley commented Oct 1, 2025

📑 Summary

Resolves #1249

Allows multi line comments to be added using %%* and *%%

  • The first line must begin with %%* for the block comment to be recognised (White space before it is allowed)
  • The last line must end with *%% for the block comment to be recognised
  • The first line is allowed to also be the last line

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: 4ac998e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 1, 2025

Deploy Preview for mermaid-js failed.

Name Link
🔨 Latest commit 4ac998e
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/694497e272cfdd0008dc1a8e

@github-actions github-actions bot added the Type: Enhancement New feature or request label Oct 1, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 1, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7028

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7028

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7028

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7028

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7028

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7028

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7028

commit: 4ac998e

@bwinsley bwinsley force-pushed the feature/1249_block-comments branch from b4cc59a to 13c0546 Compare December 16, 2025 06:05
@argos-ci
Copy link

argos-ci bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 19, 2025, 12:19 AM

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.56%. Comparing base (7b167cf) to head (4ac998e).

Files with missing lines Patch % Lines
packages/mermaid/src/diagram-api/comments.ts 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7028      +/-   ##
==========================================
- Coverage     3.56%   3.56%   -0.01%     
==========================================
  Files          473     474       +1     
  Lines        47566   47582      +16     
  Branches       734     734              
==========================================
  Hits          1696    1696              
- Misses       45870   45886      +16     
Flag Coverage Δ
unit 3.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagram-api/comments.ts 11.11% <0.00%> (-13.89%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bwinsley
Copy link
Author

Hi @sidharthv96, there seems to be an issue with ESLint in the CI for this PR. Is there something I need to do to get this working?

@bwinsley bwinsley closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block Comments

1 participant